Skip to content

Commit 1aecdae

Browse files
committed
address comments
1 parent 1b3aa1d commit 1aecdae

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

tests/run-browser.mjs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ const TESTS = [
5050
},
5151
{
5252
name: "Run Tag No Prefetch",
53-
tags: ["all", "all", "main"],
53+
tags: ["all", "main"],
5454
run() {
5555
return runEnd2EndTest("Run Tag No Prefetch", { tag: "proxy", prefetchResources: "false" });
5656
}
@@ -138,9 +138,6 @@ async function runTests() {
138138

139139
const testsToRun = TESTS.filter(test => test.tags.includes(suiteFilter));
140140

141-
console.log(testsToRun)
142-
console.log(testsToRun.length)
143-
console.log(suiteFilter)
144141
if (testsToRun.length === 0) {
145142
console.error(`No suite found for filter: ${suiteFilter}`);
146143
process.exit(1);

tests/run-shell.mjs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,10 @@ function runCLITest(name, shellBinary, ...args) {
214214

215215
async function runShell(shellBinary, ...args) {
216216
const result = await sh(shellBinary, ...args);
217-
if (result.stdoutString.includes("JetStream3 failed")) throw new Error("test failed");
217+
// JSC does not set a non-0 exit status on async exceptions.
218+
if (SHELL_NAME == "javascriptcore" && "JetStream3 failed") {
219+
throw new Error("test failed");
220+
}
218221
}
219222

220223
setImmediate(runTests);

0 commit comments

Comments
 (0)