cleanup comments

Author: danleh

Kotlin-compose/benchmark.js

@@ -71,36 +71,25 @@ globalThis.WebAssembly.instantiateStreaming = async function(m,i) {
 };
 
 // Provide `setTimeout` for Kotlin coroutines.
-// Deep in the Compose UI framework, one task is scheduled every 16ms, see
-// https://github.com/JetBrains/compose-multiplatform-core/blob/a52f2981b9bc7cdba1d1fbe71654c4be448ebea7/compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/spatial/RectManager.kt#L138
-// and
-// https://github.com/JetBrains/compose-multiplatform-core/blob/a52f2981b9bc7cdba1d1fbe71654c4be448ebea7/compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/layout/OnLayoutRectChangedModifier.kt#L56
-// We don't want to delay work in the Wall-time based measurement in JetStream,
-// but executing this immediately (without delay) produces redundant work that 
-// is not realistic for a full-browser Kotlin/multiplatform application either,
-// according to Kotlin/JetBrains folks.
-// Hence the early return for 16ms delays below.
-// FIXME: The SpiderMonkey shell doesn't have `setTimeout` (yet). We could also
-// polyfill this with `Promise.resolve().then(f)`, but that changes the CPU
-// profile slightly on other engines, so it's probably best to just add support.
 const originalSetTimeout = setTimeout;
 globalThis.setTimeout = function(f, delayMs) {
   // DEBUG
   // console.log('setTimeout', f, t);
 
+  // Deep in the Compose UI framework, one task is scheduled every 16ms, see
+  // https://github.com/JetBrains/compose-multiplatform-core/blob/a52f2981b9bc7cdba1d1fbe71654c4be448ebea7/compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/spatial/RectManager.kt#L138
+  // and
+  // https://github.com/JetBrains/compose-multiplatform-core/blob/a52f2981b9bc7cdba1d1fbe71654c4be448ebea7/compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/layout/OnLayoutRectChangedModifier.kt#L56
+  // We don't want to delay work in the Wall-time based measurement in JetStream,
+  // but executing this immediately (without delay) produces redundant work that 
+  // is not realistic for a full-browser Kotlin/multiplatform application either,
+  // according to Kotlin/JetBrains folks.
+  // Hence the early return for 16ms delays.
   if (delayMs === 16) return;
   if (delayMs !== 0) {
     throw new Error('Unexpected delay for setTimeout polyfill: ' + delayMs);
   }
   originalSetTimeout(f);
-  
-  // Alternative, if setTimeout is not available in a shell (but that changes
-  // the performance profile a little bit, so I'd rather not do that):
-  // Promise.resolve().then(f);
-
-  // Yet another alternative is to run the task synchronously, but that obviously
-  // overflows the stack at some point if the callback itself spawns more work:
-  // f();
 }
 
 // Don't automatically run the main function on instantiation.

Kotlin-compose/build.sh

@@ -15,7 +15,7 @@ echo -e "Built on $(date --rfc-3339=seconds)" | tee "$BUILD_LOG"
 git clone -b ok/jetstream3_hotfix https://github.com/JetBrains/compose-multiplatform.git |& tee -a "$BUILD_LOG"
 pushd compose-multiplatform/
 git log -1 --oneline | tee -a "$BUILD_LOG"
-# FIXME: Use stable 2.3 Kotlin/Wasm toolchain, once available.
+# FIXME: Use stable 2.3 Kotlin/Wasm toolchain, once available around Sep 2025.
 git apply ../use-beta-toolchain.patch | tee -a "$BUILD_LOG"
 pushd benchmarks/multiplatform
 ./gradlew :benchmarks:wasmJsProductionExecutableCompileSync
@@ -29,7 +29,8 @@ echo "Copying generated files into build/" | tee -a "$BUILD_LOG"
 mkdir -p build/ | tee -a "$BUILD_LOG"
 cp $BUILD_SRC_DIR/compose-benchmarks-benchmarks.{wasm,uninstantiated.mjs} build/ | tee -a "$BUILD_LOG"
 git apply hook-print.patch | tee -a "$BUILD_LOG"
-# TODO: Remove once either the Kotlin toolchain or JSC fixes the issue raised in https://github.com/WebKit/JetStream/pull/84#issuecomment-3164672425
+# FIXME: Remove once the JSC fixes around JSTag have landed in Safari, see
+# https://github.com/WebKit/JetStream/pull/84#issuecomment-3164672425.
 git apply jstag-workaround.patch | tee -a "$BUILD_LOG"
 cp $BUILD_SRC_DIR/skiko.{wasm,mjs} build/ | tee -a "$BUILD_LOG"
 git apply skiko-disable-instantiate.patch | tee -a "$BUILD_LOG"