From 8538f1f3e56d36d6763b2166056aa9901050144d Mon Sep 17 00:00:00 2001
From: Camillo Bruni <cbruni@chromium.org>
Date: Thu, 31 Jul 2025 14:17:24 +0200
Subject: [PATCH 1/7] cleanup

---
 JetStreamDriver.js | 262 +++++++++++++++++++++++++--------------------
 1 file changed, 148 insertions(+), 114 deletions(-)
diff --git a/JetStreamDriver.js b/JetStreamDriver.js
index 21b16394..2364032c 100644
--- a/JetStreamDriver.js
+++ b/JetStreamDriver.js
@@ -310,51 +310,8 @@ class Driver {
 
     runCode(string) {
         if (!isInBrowser) {
-            const scripts = string;
-            let globalObject;
-            let realm;
-            if (isD8) {
-                realm = Realm.createAllowCrossRealmAccess();
-                globalObject = Realm.global(realm);
-                globalObject.loadString = function(s) {
-                    return Realm.eval(realm, s);
-                };
-                globalObject.readFile = read;
-            } else if (isSpiderMonkey) {
-                globalObject = newGlobal();
-                globalObject.loadString = globalObject.evaluate;
-                globalObject.readFile = globalObject.readRelativeToScript;
-            } else
-                globalObject = runString("");
-
-            globalObject.console = {
-                log: globalObject.print,
-                warn: (e) => { print("Warn: " + e); },
-                error: (e) => { print("Error: " + e); },
-                debug: (e) => { print("Debug: " + e); },
-            };
-
-            globalObject.self = globalObject;
-            globalObject.top = {
-                currentResolve,
-                currentReject
-            };
-
-            globalObject.performance ??= performance;
-            for (const script of scripts)
-                globalObject.loadString(script);
 
-            return isD8 ? realm : globalObject;
         }
-
-        const magic = document.getElementById("magic");
-        magic.contentDocument.body.textContent = "";
-        magic.contentDocument.body.innerHTML = "<iframe id=\"magicframe\" frameborder=\"0\">";
-
-        const magicFrame = magic.contentDocument.getElementById("magicframe");
-        magicFrame.contentDocument.open();
-        magicFrame.contentDocument.write(`<!DOCTYPE html><head><title>benchmark payload</title></head><body>\n${string}</body></html>`);
-
         return magicFrame;
     }
 
@@ -574,6 +531,142 @@ const BenchmarkState = Object.freeze({
     DONE: "DONE"
 })
 
+
+class Scripts {
+    constructor() {
+        this.scripts = [];
+    }
+
+    add(text) {
+        assert(false, "Not implemented");
+    }
+
+    addWithURL(url) {
+        assert(false, "Not implemented");
+    }
+
+    addUtils() {
+        this.add(`
+            const isInBrowser = ${isInBrowser};
+            const isD8 = ${isD8};
+            if (typeof performance.mark === 'undefined') {
+                performance.mark = function(name) { return { name }};
+            }
+            if (typeof performance.measure === 'undefined') {
+                performance.measure = function() {};
+            }
+        `);
+    }
+
+
+    addDeterministicRandom() {
+        this.add(`
+          (() => {
+                const initialSeed = 49734321;
+                let seed = initialSeed;
+
+                Math.random = () => {
+                    // Robert Jenkins' 32 bit integer hash function.
+                    seed = ((seed + 0x7ed55d16) + (seed << 12))  & 0xffff_ffff;
+                    seed = ((seed ^ 0xc761c23c) ^ (seed >>> 19)) & 0xffff_ffff;
+                    seed = ((seed + 0x165667b1) + (seed << 5))   & 0xffff_ffff;
+                    seed = ((seed + 0xd3a2646c) ^ (seed << 9))   & 0xffff_ffff;
+                    seed = ((seed + 0xfd7046c5) + (seed << 3))   & 0xffff_ffff;
+                    seed = ((seed ^ 0xb55a4f09) ^ (seed >>> 16)) & 0xffff_ffff;
+                    // Note that Math.random should return a value that is
+                    // greater than or equal to 0 and less than 1. Here, we
+                    // cast to uint32 first then divided by 2^32 for double.
+                    return (seed >>> 0) / 0x1_0000_0000;
+                };
+
+                Math.random.__resetSeed = () => {
+                    seed = initialSeed;
+                };
+            })();
+        `);
+    }
+}
+
+class ShellScripts extends Scripts {
+    run() {
+        let globalObject;
+        let realm;
+        if (isD8) {
+            realm = Realm.createAllowCrossRealmAccess();
+            globalObject = Realm.global(realm);
+            globalObject.loadString = function(s) {
+                return Realm.eval(realm, s);
+            };
+            globalObject.readFile = read;
+        } else if (isSpiderMonkey) {
+            globalObject = newGlobal();
+            globalObject.loadString = globalObject.evaluate;
+            globalObject.readFile = globalObject.readRelativeToScript;
+        } else
+            globalObject = runString("");
+
+        globalObject.console = {
+            log: globalObject.print,
+            warn: (e) => { print("Warn: " + e); },
+            error: (e) => { print("Error: " + e); },
+            debug: (e) => { print("Debug: " + e); },
+        };
+
+        globalObject.self = globalObject;
+        globalObject.top = {
+            currentResolve,
+            currentReject
+        };
+
+        globalObject.performance ??= performance;
+        for (const script of this.scripts)
+            globalObject.loadString(script);
+
+        return isD8 ? realm : globalObject;
+    }
+
+    add(text) {
+        this.scripts.push(text);
+    }
+
+    addWithURL(url) {
+        assert(false, "Should not reach here in CLI");
+    }
+}
+
+class BrowserScripts extends Scripts {
+    constructor() {
+        super();
+        this.add("window.onerror = top.currentReject;");
+    }
+
+    run() {
+        const string = this.scripts.join("\n");
+        const magic = document.getElementById("magic");
+        magic.contentDocument.body.textContent = "";
+        magic.contentDocument.body.innerHTML = `<iframe id="magicframe" frameborder="0">`;
+
+        const magicFrame = magic.contentDocument.getElementById("magicframe");
+        magicFrame.contentDocument.open();
+        magicFrame.contentDocument.write(`<!DOCTYPE html>
+            <head>
+               <title>benchmark payload</title>
+            </head>
+            <body>${string}</body>
+        </html>`);
+        return magicFrame;
+    }
+
+
+    add(text) {
+        this.scripts.push(`<script>${text}</script>`);
+    }
+
+    addWithURL(url) {
+        this.scripts.push(`<script src="${url}"></script>`);
+    }
+}
+
 class Benchmark {
     constructor(plan)
     {
@@ -678,84 +771,31 @@ class Benchmark {
         if (this.isDone)
             throw new Error(`Cannot run Benchmark ${this.name} twice`);
         this._state = BenchmarkState.PREPARE;
-        let code;
-        if (isInBrowser)
-            code = "";
-        else
-            code = [];
-
-        const addScript = (text) => {
-            if (isInBrowser)
-                code += `<script>${text}</script>`;
-            else
-                code.push(text);
-        };
-
-        const addScriptWithURL = (url) => {
-            if (isInBrowser)
-                code += `<script src="${url}"></script>`;
-            else
-                assert(false, "Should not reach here in CLI");
-        };
-
-        addScript(`
-            const isInBrowser = ${isInBrowser};
-            const isD8 = ${isD8};
-            if (typeof performance.mark === 'undefined') {
-                performance.mark = function(name) { return { name }};
-            }
-            if (typeof performance.measure === 'undefined') {
-                performance.measure = function() {};
-            }
-        `);
+        const scripts = isInBrowser ? new BrowserScripts() : new ShellScripts();
 
-        if (!!this.plan.deterministicRandom) {
-            addScript(`
-                 (() => {
-                    const initialSeed = 49734321;
-                    let seed = initialSeed;
-
-                    Math.random = () => {
-                        // Robert Jenkins' 32 bit integer hash function.
-                        seed = ((seed + 0x7ed55d16) + (seed << 12))  & 0xffff_ffff;
-                        seed = ((seed ^ 0xc761c23c) ^ (seed >>> 19)) & 0xffff_ffff;
-                        seed = ((seed + 0x165667b1) + (seed << 5))   & 0xffff_ffff;
-                        seed = ((seed + 0xd3a2646c) ^ (seed << 9))   & 0xffff_ffff;
-                        seed = ((seed + 0xfd7046c5) + (seed << 3))   & 0xffff_ffff;
-                        seed = ((seed ^ 0xb55a4f09) ^ (seed >>> 16)) & 0xffff_ffff;
-                        // Note that Math.random should return a value that is
-                        // greater than or equal to 0 and less than 1. Here, we
-                        // cast to uint32 first then divided by 2^32 for double.
-                        return (seed >>> 0) / 0x1_0000_0000;
-                    };
-
-                    Math.random.__resetSeed = () => {
-                        seed = initialSeed;
-                    };
-                })();
-            `);
-        }
+        scripts.addUtils();
+        if (!!this.plan.deterministicRandom)
+            scripts.addDeterministicRandom()
 
         if (this.plan.preload) {
-            let str = "";
+            let preloadCode = "";
             for (let [ variableName, blobURLOrPath ] of this.preloads)
-                str += `const ${variableName} = "${blobURLOrPath}";\n`;
-            addScript(str);
+                preloadCode += `const ${variableName} = "${blobURLOrPath}";\n`;
+            scripts.add(preloadCode);
         }
 
         const prerunCode = this.prerunCode;
         if (prerunCode)
-            addScript(prerunCode);
+            scripts.add(prerunCode);
 
         if (!isInBrowser) {
             assert(this.scripts && this.scripts.length === this.plan.files.length);
-
             for (const text of this.scripts)
-                addScript(text);
+                scripts.add(text);
         } else {
             const cache = JetStream.blobDataCache;
             for (const file of this.plan.files)
-                addScriptWithURL(cache[file].blobURL);
+                scripts.addWithURL(cache[file].blobURL);
         }
 
         const promise = new Promise((resolve, reject) => {
@@ -763,13 +803,7 @@ class Benchmark {
             currentReject = reject;
         });
 
-        if (isInBrowser) {
-            code = `
-                <script> window.onerror = top.currentReject; </script>
-                ${code}
-            `;
-        }
-        addScript(this.runnerCode);
+        scripts.add(this.runnerCode);
 
         this.startTime = performance.now();
 
@@ -779,7 +813,7 @@ class Benchmark {
         let magicFrame;
         try {
             this._state = BenchmarkState.RUNNING;
-            magicFrame = JetStream.runCode(code);
+            magicFrame = scripts.run();
         } catch(e) {
             this._state = BenchmarkState.ERROR;
             console.log("Error in runCode: ", e);

From 047101699d56f9ada266e574cd7347e1bbed0544 Mon Sep 17 00:00:00 2001
From: Camillo Bruni <cbruni@chromium.org>
Date: Thu, 31 Jul 2025 14:20:53 +0200
Subject: [PATCH 2/7] better errors

---
 JetStreamDriver.js | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/JetStreamDriver.js b/JetStreamDriver.js
index 2364032c..b65c54b5 100644
--- a/JetStreamDriver.js
+++ b/JetStreamDriver.js
@@ -537,12 +537,16 @@ class Scripts {
         this.scripts = [];
     }
 
+    run() {
+        throw new Error("Subclasses need to implement this");
+    }
+
     add(text) {
-        assert(false, "Not implemented");
+        throw new Error("Subclasses need to implement this");
     }
 
     addWithURL(url) {
-        assert(false, "Not implemented");
+        throw new Error("Subclasses need to implement this");
     }
 
     addUtils() {

From 6235312b6d1f4e56cf9a6ba5c031a0f72c5a955d Mon Sep 17 00:00:00 2001
From: Camillo Bruni <cbruni@chromium.org>
Date: Thu, 31 Jul 2025 14:21:28 +0200
Subject: [PATCH 3/7] better error messages

---
 JetStreamDriver.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/JetStreamDriver.js b/JetStreamDriver.js
index b65c54b5..1d251755 100644
--- a/JetStreamDriver.js
+++ b/JetStreamDriver.js
@@ -546,7 +546,7 @@ class Scripts {
     }
 
     addWithURL(url) {
-        throw new Error("Subclasses need to implement this");
+        throw new Error("addWithURL not supported");
     }
 
     addUtils() {

From 239c0274541dc35b33029134a9fc055d34f96a30 Mon Sep 17 00:00:00 2001
From: Camillo Bruni <cbruni@chromium.org>
Date: Thu, 31 Jul 2025 14:22:10 +0200
Subject: [PATCH 4/7] more cleanup

---
 JetStreamDriver.js | 44 +++++++++++++++++++++-----------------------
 1 file changed, 21 insertions(+), 23 deletions(-)

diff --git a/JetStreamDriver.js b/JetStreamDriver.js
index 1d251755..d5511912 100644
--- a/JetStreamDriver.js
+++ b/JetStreamDriver.js
@@ -564,30 +564,28 @@ class Scripts {
 
 
     addDeterministicRandom() {
-        this.add(`
-          (() => {
-                const initialSeed = 49734321;
-                let seed = initialSeed;
-
-                Math.random = () => {
-                    // Robert Jenkins' 32 bit integer hash function.
-                    seed = ((seed + 0x7ed55d16) + (seed << 12))  & 0xffff_ffff;
-                    seed = ((seed ^ 0xc761c23c) ^ (seed >>> 19)) & 0xffff_ffff;
-                    seed = ((seed + 0x165667b1) + (seed << 5))   & 0xffff_ffff;
-                    seed = ((seed + 0xd3a2646c) ^ (seed << 9))   & 0xffff_ffff;
-                    seed = ((seed + 0xfd7046c5) + (seed << 3))   & 0xffff_ffff;
-                    seed = ((seed ^ 0xb55a4f09) ^ (seed >>> 16)) & 0xffff_ffff;
-                    // Note that Math.random should return a value that is
-                    // greater than or equal to 0 and less than 1. Here, we
-                    // cast to uint32 first then divided by 2^32 for double.
-                    return (seed >>> 0) / 0x1_0000_0000;
-                };
+        this.add(`(() => {
+            const initialSeed = 49734321;
+            let seed = initialSeed;
+
+            Math.random = () => {
+                // Robert Jenkins' 32 bit integer hash function.
+                seed = ((seed + 0x7ed55d16) + (seed << 12))  & 0xffff_ffff;
+                seed = ((seed ^ 0xc761c23c) ^ (seed >>> 19)) & 0xffff_ffff;
+                seed = ((seed + 0x165667b1) + (seed << 5))   & 0xffff_ffff;
+                seed = ((seed + 0xd3a2646c) ^ (seed << 9))   & 0xffff_ffff;
+                seed = ((seed + 0xfd7046c5) + (seed << 3))   & 0xffff_ffff;
+                seed = ((seed ^ 0xb55a4f09) ^ (seed >>> 16)) & 0xffff_ffff;
+                // Note that Math.random should return a value that is
+                // greater than or equal to 0 and less than 1. Here, we
+                // cast to uint32 first then divided by 2^32 for double.
+                return (seed >>> 0) / 0x1_0000_0000;
+            };
 
-                Math.random.__resetSeed = () => {
-                    seed = initialSeed;
-                };
-            })();
-        `);
+            Math.random.__resetSeed = () => {
+                seed = initialSeed;
+            };
+        })();`);
     }
 }
 

From 659b2413230ab462120dc03183dc88ff0cc7db6c Mon Sep 17 00:00:00 2001
From: Camillo Bruni <cbruni@chromium.org>
Date: Thu, 31 Jul 2025 15:40:38 +0200
Subject: [PATCH 5/7] remove unused runCode method

---
 JetStreamDriver.js | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/JetStreamDriver.js b/JetStreamDriver.js
index d5511912..112064a8 100644
--- a/JetStreamDriver.js
+++ b/JetStreamDriver.js
@@ -308,13 +308,6 @@ class Driver {
         }
     }
 
-    runCode(string) {
-        if (!isInBrowser) {
-
-        }
-        return magicFrame;
-    }
-
     prepareToRun() {
         this.benchmarks.sort((a, b) => a.plan.name.toLowerCase() < b.plan.name.toLowerCase() ? 1 : -1);
 

From dcc038815c9e4673d25e8824e5e3c436a1ab4a42 Mon Sep 17 00:00:00 2001
From: Camillo Bruni <cbruni@chromium.org>
Date: Mon, 4 Aug 2025 18:32:19 +0200
Subject: [PATCH 6/7] fix

---
 JetStreamDriver.js | 1 -
 1 file changed, 1 deletion(-)

diff --git a/JetStreamDriver.js b/JetStreamDriver.js
index 112064a8..a9eb0fce 100644
--- a/JetStreamDriver.js
+++ b/JetStreamDriver.js
@@ -555,7 +555,6 @@ class Scripts {
         `);
     }
 
-
     addDeterministicRandom() {
         this.add(`(() => {
             const initialSeed = 49734321;

From 1b68ccac60301a7b33bd1be349bc60a667b7cec6 Mon Sep 17 00:00:00 2001
From: Camillo Bruni <cbruni@chromium.org>
Date: Tue, 5 Aug 2025 15:57:10 +0200
Subject: [PATCH 7/7] address comments

---
 JetStreamDriver.js | 24 ++++++++++--------------
 1 file changed, 10 insertions(+), 14 deletions(-)

diff --git a/JetStreamDriver.js b/JetStreamDriver.js
index 261ce08f..6b4c6668 100644
--- a/JetStreamDriver.js
+++ b/JetStreamDriver.js
@@ -532,6 +532,16 @@ const BenchmarkState = Object.freeze({
 class Scripts {
     constructor() {
         this.scripts = [];
+        this.add(`
+            const isInBrowser = ${isInBrowser};
+            const isD8 = ${isD8};
+            if (typeof performance.mark === 'undefined') {
+                performance.mark = function(name) { return { name }};
+            }
+            if (typeof performance.measure === 'undefined') {
+                performance.measure = function() {};
+            }
+        `);
     }
 
     run() {
@@ -546,19 +556,6 @@ class Scripts {
         throw new Error("addWithURL not supported");
     }
 
-    addUtils() {
-        this.add(`
-            const isInBrowser = ${isInBrowser};
-            const isD8 = ${isD8};
-            if (typeof performance.mark === 'undefined') {
-                performance.mark = function(name) { return { name }};
-            }
-            if (typeof performance.measure === 'undefined') {
-                performance.measure = function() {};
-            }
-        `);
-    }
-
     addDeterministicRandom() {
         this.add(`(() => {
             const initialSeed = 49734321;
@@ -771,7 +768,6 @@ class Benchmark {
         this._state = BenchmarkState.PREPARE;
         const scripts = isInBrowser ? new BrowserScripts() : new ShellScripts();
 
-        scripts.addUtils();
         if (!!this.plan.deterministicRandom)
             scripts.addDeterministicRandom()
 
