Use tags for workload selection#82
Conversation
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
gentle ping. |
| , "./ARES-6/Air/benchmark.js" | ||
| ], | ||
| tags: ["ARES"], | ||
| tags: ["default", "ARES"], |
There was a problem hiding this comment.
Nit: The other tags seem to be CamelCase so maybe this should be Default to be consistent.
There was a problem hiding this comment.
come to think, having tags lower case is probably the most convenient (and would be in sync with what we do in speedometer).
Then we can alos easily ignore the case when trying to enable tags groups.
WDYT?
There was a problem hiding this comment.
That's fine with me. Case sensitivity for debugging options is inconvenient in my experience.
There was a problem hiding this comment.
That said, CamelCase is usually easier to read since it demarks different parts of the word. I'm happy to switch to camelCase though too.
There was a problem hiding this comment.
- Changed to "Default"
- Internally all tags are lowercase
- Added check for duplicate tags, so we don't accidentally have an issue mixing same tags with different upper/lower cases
kmiller68
left a comment
kmiller68
left a comment
There was a problem hiding this comment.
LGTM other than the order change
tag, thus stopped running by default. This adds the "Default" tag so the dotnet benchmarks run again by default.
2 participants
tagas urlParam