Use Params.prototype.toSearchParams() in developer-mode.mjs#511
Merged
camillobruni merged 3 commits intoMay 5, 2025
Conversation
camillobruni
changed the title
✅ Deploy Preview for webkit-speedometer-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
camillobruni
added
the
trivial change
julienw
approved these changes
May 5, 2025
julienw
left a comment
julienw
left a comment
Contributor
There was a problem hiding this comment.
looks good to me, thanks
I noticed one small bug (that was present before): after clicking "unselect all", I expect to see the parameter suites=, but instead the parameter disappears completely. So when reloading the page we're back to the default set of suites.
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove duplicated code and directly use
Params.prototype.toSearchParams().Now the Params class is the centralized place to implement the serialization logic.