[MessageControl] Do not create a worker thread in DirectOutput#385
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the MessageControl plugin to avoid creating (and managing) a worker thread when running in “DirectOutput” mode where no messaging data buffer exists.
Changes:
- Make the
WorkerThreadoptional by storing it as a pointer and guarding usage with null checks. - Conditionally create the worker thread only when
Messaging::MessageUnit::Instance().DataSize() != 0. - Update shutdown and callback handling to account for the optional worker thread.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| MessageControl/MessageControl.h | Switches _worker to an optional pointer and adds null-guarded lifecycle/callback logic. |
| MessageControl/MessageControl.cpp | Initializes _worker to null and conditionally allocates it based on DataSize(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sebaszm
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.