fix(api-client): fix handling of exposed ports without host bindings

Author: Fahl-Design

src/Util/ContainerResponseToContainerDtoUtil.php

@@ -42,6 +42,8 @@ public function __invoke(
         $ports = [];
         foreach ($networkSettings->getPorts() ?? [] as $portKey => $portBindings) {
             if (empty($portBindings)) {
+                // PortBindung without host binding
+                $ports[$portKey] = new \WebProject\DockerApi\Library\Generated\Model\PortBinding();
                 continue;
             }
             // PortBinding is expected by DTO for each string key

tests/Unit/Util/ContainerResponseToContainerDtoUtilTest.php

@@ -6,6 +6,7 @@
 
 use PHPUnit\Framework\Attributes\CoversClass;
 use WebProject\DockerApi\Library\Generated\Model\EndpointSettings;
+use WebProject\DockerApi\Library\Generated\Model\PortBinding;
 use WebProject\DockerApiClient\Util\ContainerResponseToContainerDtoUtil;
 
 #[CoversClass(ContainerResponseToContainerDtoUtil::class)]
@@ -59,9 +60,10 @@ public function testInvokeMaxValues(): void
 
         $networkSettings = new \WebProject\DockerApi\Library\Generated\Model\NetworkSettings();
         $networkSettings->setNetworks(networks: ['ca7d9ec2cf61951cf24ed7c91006927fa1259aabaf07e334f5e0b0fe36ce5794' => $endpoint, '4a7d9ec2cf61951cf24ed7c91006927fa1259aabaf07e334f5e0b0fe36ce5794' =>  $endpoint2]);
-        $networkSettings->setPorts([]);
+        $networkSettings->setPorts(['5006/tcp' => []]);
 
         $containerInspectResponse->setNetworkSettings(networkSettings: $networkSettings);
+        $containerInspectResponse->setState(state: (new \WebProject\DockerApi\Library\Generated\Model\ContainerState())->setRunning(running: true));
 
         $containerConfig = new \WebProject\DockerApi\Library\Generated\Model\ContainerConfig();
         $containerConfig->setEnv(
@@ -104,12 +106,45 @@ public function testInvokeMaxValues(): void
             ],
         ];
         $this->assertSame($expectedNetworks, $containerDto->networks);
-        $this->assertFalse($containerDto->running);
+        $this->assertTrue($containerDto->running);
         $this->assertSame('container-name', $containerDto->getName());
         $this->assertSame(['container-name'], $containerDto->getHostnames(tld: ''));
         $this->assertSame(
             ['actual.reverse-proxy-subdomain.xyz', 'domain-name.reverse-proxy-subdomain.xyz'],
             $containerDto->extractUrlsFromEnvVars(extractFromEnvVars: ['DOMAIN_NAME', 'VIRTUAL_HOST'])
         );
+        $this->assertTrue($containerDto->isExposed());
+    }
+
+    public function testExposedPortsWithoutHostBindingAreValid(): void
+    {
+        // Arrange
+        $containerInspectResponse = new \WebProject\DockerApi\Library\Generated\Model\ContainerInspectResponse();
+        $containerInspectResponse->setId(id: 'container-idValue');
+        $containerInspectResponse->setImage(image: 'container-imageValue');
+        $containerInspectResponse->setName(name: '/container-name');
+
+        $networkSettings = new \WebProject\DockerApi\Library\Generated\Model\NetworkSettings();
+        $networkSettings->setNetworks(networks: []);
+        $networkSettings->setPorts(ports: ['80/tcp' => [], '8080/tcp' => [new PortBinding()]]);
+        $containerInspectResponse->setNetworkSettings(networkSettings: $networkSettings);
+
+        $containerConfig = new \WebProject\DockerApi\Library\Generated\Model\ContainerConfig();
+        $containerConfig->setEnv(env: []);
+        $containerInspectResponse->setConfig(config: $containerConfig);
+        $containerInspectResponse->setState(state: (new \WebProject\DockerApi\Library\Generated\Model\ContainerState())->setRunning(running: true));
+
+        // Act
+        $containerDto = (new ContainerResponseToContainerDtoUtil())(containerInspect: $containerInspectResponse);
+
+        // Assert
+        $this->assertSame('container-idValue', $containerDto->id);
+        $this->assertSame('container-imageValue', $containerDto->image);
+        $this->assertSame([], $containerDto->ipAddresses);
+        $this->assertSame([], $containerDto->networks);
+        $this->assertTrue($containerDto->running);
+        $this->assertSame('container-name', $containerDto->getName());
+        $this->assertSame(['container-name'], $containerDto->getHostnames(tld: ''));
+        $this->assertTrue($containerDto->isExposed());
     }
 }