fix: address CodeRabbit review on PR #19

- self_update: fall back to CARGO_PKG_VERSION when PVM_VERSION is not
  valid semver so non-tagged/CI builds still parse a usable version.
- self_update: propagate dialoguer prompt errors via .context()? instead
  of silently mapping them to a user cancellation.
- tests: isolate the two new self-update CLI tests with tempdir + PVM_DIR
  per the project's integration-test convention.

Author: Fahl-Design

src/commands/self_update.rs

@@ -26,12 +26,14 @@ fn current_version() -> Result<semver::Version> {
     let trimmed = token.trim_start_matches('v');
     // git-describe extras (e.g. "-2-gabc") are not valid semver; drop them.
     let core = trimmed.split('-').next().unwrap_or(trimmed);
-    semver::Version::parse(core).with_context(|| {
-        format!(
-            "Failed to parse current pvm version '{}' from '{}'",
-            core, raw
-        )
-    })
+    semver::Version::parse(core)
+        .or_else(|_| semver::Version::parse(env!("CARGO_PKG_VERSION")))
+        .with_context(|| {
+            format!(
+                "Failed to parse current pvm version '{}' from '{}'",
+                core, raw
+            )
+        })
 }
 
 fn parse_remote_version(tag: &str) -> Result<semver::Version> {
@@ -174,7 +176,7 @@ impl SelfUpdate {
             .with_prompt(format!("Update pvm to {}?", remote_str).bold().to_string())
             .default(true)
             .interact_opt()
-            .unwrap_or(Some(false))
+            .context("Failed to read update confirmation from terminal")?
             .unwrap_or(false);
 
         if !confirmed {

tests/cli.rs

@@ -29,7 +29,9 @@ fn test_version_short() {
 
 #[test]
 fn test_self_update_help() {
+    let temp_dir = tempfile::tempdir().unwrap();
     let mut cmd = assert_cmd::cargo::cargo_bin_cmd!("pvm");
+    cmd.env("PVM_DIR", temp_dir.path());
     cmd.arg("self-update").arg("--help");
     cmd.assert()
         .success()
@@ -38,7 +40,9 @@ fn test_self_update_help() {
 
 #[test]
 fn test_help_lists_self_update() {
+    let temp_dir = tempfile::tempdir().unwrap();
     let mut cmd = assert_cmd::cargo::cargo_bin_cmd!("pvm");
+    cmd.env("PVM_DIR", temp_dir.path());
     cmd.arg("--help");
     cmd.assert()
         .success()