fix(ci): pin build matrix toolchain to 1.95.0#21
Conversation
The build job used dtolnay/rust-toolchain without a toolchain input, which installs 'stable' and adds the matrix target to it. But rust-toolchain.toml pins channel 1.95.0, so cargo activates 1.95.0 at build time without the cross-compilation target installed, producing 'error[E0463]: can't find crate for core' on x86_64-apple-darwin. fail-fast then cancelled the aarch64 and linux jobs, leaving the v1.1.0 release with zero binary assets and breaking install.sh (404). Pin the action to toolchain 1.95.0 explicitly and forward components clippy/rustfmt to match rust-toolchain.toml so the requested target is installed against the toolchain cargo will actually use. Fixes #20
|
Warning Rate limit exceeded
To continue reviewing without waiting, purchase usage credits in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🎉 This PR is included in version 1.1.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
1 participant
Summary
release.ymlinstalledstabletoolchain viadtolnay/rust-toolchain, butrust-toolchain.tomlpins channel1.95.0. Targets were added tostable, then cargo activated1.95.0without the cross-compilation target →error[E0463]: can't find crate for coreonx86_64-apple-darwin.fail-fastcancelled the other archs, so v1.1.0 was published with zero binary assets —install.sh404s on every platform.toolchain: "1.95.0"andcomponents: clippy, rustfmtto the action so the matrix target is installed against the toolchain cargo actually uses.Test plan
Lint & Testjob greenv1.1.1Buildjobs succeedv1.1.1release containspvm-linux-x86_64.tar.gz,pvm-macos-aarch64.tar.gz,pvm-macos-x86_64.tar.gzcurl -fsSL https://raw.githubusercontent.com/WebProject-xyz/php-version-manager/main/install.sh | bashsucceeds on macOS aarch64 (issue Cannot install on MacOs #20 reproducer)Fixes #20