Skip to content

Commit 84e409c

Browse files
committed
show unsupported keys
1 parent 945c2ea commit 84e409c

4 files changed

Lines changed: 31 additions & 7 deletions

File tree

_layouts/feature.html

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -176,20 +176,27 @@ <h4 class="data-platform-name">
176176
<div class="data-notes">
177177
{% if has-page-notes == true or page.notes_by_num.size > 0 %}
178178
<h2 class="list-title">Notes</h2>
179-
{% if has-page-notes == true %}
180-
{{ page.notes | markdownify }}
181-
{% endif %}
182179
{% if page.notes_by_num.size > 0 %}
180+
<h3 class="list-subtitle">Unsupported keys in WebViews</h3>
183181
<ul class="data-notes-list">
184182
{% for note in page.notes_by_num %}
185183
{% assign note-key = note | first %}
186184
{% assign note-value = note | last %}
187185
<li class="data-note" id="{{ page.slug }}-cite-note-{{ note-key | slugify }}">
188-
<span class="data-note-key">{{ note-key }}</span> {{ note-value | markdownify }}
186+
<b>{{ site.data.nicenames.family[note-key] }}:</b>
187+
<div class="note-tags">
188+
{% assign note-items = note-value | split: ',' %}
189+
{% for item in note-items %}
190+
<span class="tag unsupported">{{ item | strip }}</span>
191+
{% endfor %}
192+
</div>
189193
</li>
190194
{% endfor %}
191195
</ul>
192196
{% endif %}
197+
{% if has-page-notes == true %}
198+
{{ page.notes | markdownify }}
199+
{% endif %}
193200
{% endif %}
194201
{% if page.links.size > 0 %}
195202
<h2 class="list-title">Resources</h2>

_plugins/generated_features.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,7 @@ def generate_baseline(site)
158158
doc.data['notes'] = data_source
159159
doc.data['links'] = feature['links']
160160
doc.data['stats'] = feature['stats']
161+
doc.data['notes_by_num'] = feature['notes_by_num']
161162
doc.data['baseline'] = feature['baseline']
162163

163164
site.collections['generated_features'].docs << doc

_sass/_pages/_feature.scss

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -200,6 +200,10 @@
200200
background-color: #eda745 !important;
201201
}
202202

203+
.partially-header {
204+
color: #eda745 !important;
205+
}
206+
203207
.score .mitigated {
204208
background-image: repeating-linear-gradient(
205209
-45deg,
@@ -678,6 +682,17 @@
678682
}
679683
}
680684

685+
.note-tags {
686+
display: inline-flex;
687+
flex-wrap: wrap;
688+
gap: rem(4px);
689+
margin-top: rem(4px);
690+
691+
.tag {
692+
font-size: rem(14px);
693+
}
694+
}
695+
681696
.data-note-key {
682697
display: flex;
683698
justify-content: center;

tools/baseline.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ fetch(`http://unpkg.com/@mdn/browser-compat-data@${bcdVersion}/data.json`)
7474
}
7575
}
7676
};
77+
const notes = {};
7778

7879
try {
7980
const computed = computeBaseline({
@@ -109,9 +110,8 @@ fetch(`http://unpkg.com/@mdn/browser-compat-data@${bcdVersion}/data.json`)
109110
if (anySupported) {
110111
stats[platform][sub] = {
111112
"*": 'a',
112-
//"supported_keys": supportedKeys,
113-
//"unsupported_keys": unsupportedKeys
114113
};
114+
notes[platform] = unsupportedKeys.join(', ');
115115
} else {
116116
stats[platform][sub] = {
117117
"u": 'n'
@@ -142,9 +142,10 @@ fetch(`http://unpkg.com/@mdn/browser-compat-data@${bcdVersion}/data.json`)
142142
slug: 'web-feature-' + key,
143143
description: feature.description_html,
144144
category: 'web_feature',
145-
keywords: '',
145+
keywords: 'web-feature',
146146
last_test_date,
147147
stats,
148+
notes_by_num: notes,
148149
links: {},
149150
baseline: {
150151
webviewBaseline,

0 commit comments

Comments
 (0)