Update: Consolidate wizard submenu logic and bump Settings API to v2.8.1

Author: ajaydsouza

includes/admin/settings/class-settings-api.php

@@ -18,7 +18,7 @@
 /**
  * Settings API wrapper class
  *
- * @version 2.8.0
+ * @version 2.8.1
  */
 class Settings_API {
 
@@ -27,7 +27,7 @@ class Settings_API {
 	 *
 	 * @var   string
 	 */
-	public const VERSION = '2.8.0';
+	public const VERSION = '2.8.1';
 
 	/**
 	 * Settings Key.

includes/admin/settings/class-settings-wizard-api.php

@@ -233,8 +233,10 @@ public function admin_menu() {
 			array( $this, 'render_wizard_page' )
 		);
 
-		$hide_when_completed = isset( $this->args['hide_when_completed'] ) ? (bool) $this->args['hide_when_completed'] : true;
-		if ( $hide_when_completed && $this->is_wizard_completed() ) {
+		$hide_submenu = ( isset( $this->args['show_in_menu'] ) && ! $this->args['show_in_menu'] ) ||
+			( ( $this->args['hide_when_completed'] ?? true ) && $this->is_wizard_completed() );
+
+		if ( $hide_submenu ) {
 			add_action( 'admin_head', array( $this, 'hide_completed_wizard_submenu' ) );
 		}
 	}
@@ -245,9 +247,6 @@ public function admin_menu() {
 	 * @return void
 	 */
 	public function hide_completed_wizard_submenu() {
-		if ( ! $this->is_wizard_completed() ) {
-			return;
-		}
 		$slug = sanitize_key( $this->page_slug );
 		?>
 		<style>