refactor: Replace hardcoded 'FreemKit' references with dynamic prefix in Tom Select and remove unused taxonomy suggest functionality

- Use dynamic prefix for Tom Select localization object name and data attributes
- Remove taxonomy-suggest.js and related registration/enqueue code
- Delete unused tags_search AJAX method from Options_API
- Remove taxonomy search defaults from Settings_API enqueue method

Author: ajaydsouza

includes/admin/class-settings-wizard.php

@@ -403,9 +403,9 @@ public function enqueue_wizard_tom_select_data( string $hook ): void {
 
 		wp_localize_script(
 			'wz-' . $this->prefix . '-tom-select-init',
-			'FreemKitTomSelectSettings',
+			"{$this->prefix}TomSelectSettings",
 			array(
-				'prefix'          => 'FreemKit',
+				'prefix'          => $this->prefix,
 				'nonce'           => wp_create_nonce( $this->prefix . '_kit_search' ),
 				'action'          => $this->prefix . '_kit_search',
 				'endpoint'        => '',

includes/admin/class-settings.php

@@ -514,7 +514,7 @@ public static function settings_subscribers(): array {
 	 */
 	public static function get_kit_search_field_attributes( string $endpoint, array $ts_config = array() ): array {
 		$attributes = array(
-			'data-wp-prefix'   => 'FreemKit',
+			'data-wp-prefix'   => self::$prefix,
 			'data-wp-action'   => self::$prefix . '_kit_search',
 			'data-wp-nonce'    => wp_create_nonce( self::$prefix . '_kit_search' ),
 			'data-wp-endpoint' => $endpoint,
@@ -691,9 +691,9 @@ public function admin_enqueue_scripts( $hook ) {
 		// Tom Select variables.
 			wp_localize_script(
 				'wz-' . self::$prefix . '-tom-select-init',
-				'FreemKitTomSelectSettings',
+				self::$prefix . 'TomSelectSettings',
 				array(
-					'prefix'          => 'FreemKit',
+					'prefix'          => self::$prefix,
 					'nonce'           => wp_create_nonce( self::$prefix . '_kit_search' ),
 					'action'          => self::$prefix . '_kit_search',
 					'endpoint'        => '',

includes/admin/settings/class-settings-api.php

@@ -494,13 +494,6 @@ public function admin_enqueue_scripts( $hook ) {
 			self::VERSION,
 			true
 		);
-		wp_register_script(
-			'wz-' . $this->prefix . '-taxonomy-suggest',
-			plugins_url( 'js/taxonomy-suggest' . $minimize . '.js', __FILE__ ),
-			array( 'jquery' ),
-			self::VERSION,
-			true
-		);
 		wp_register_script(
 			'wz-' . $this->prefix . '-media-selector',
 			plugins_url( 'js/media-selector' . $minimize . '.js', __FILE__ ),
@@ -583,16 +576,13 @@ public static function enqueue_scripts_styles( $prefix, $args = array() ) {
 
 		wp_enqueue_script( "wz-{$prefix}-admin" );
 		wp_enqueue_script( "wz-{$prefix}-codemirror" );
-		wp_enqueue_script( "wz-{$prefix}-taxonomy-suggest" );
 		wp_enqueue_script( "wz-{$prefix}-media-selector" );
 
 		// Enqueue Tom Select.
 		wp_enqueue_style( "wz-{$prefix}-tom-select" );
 		wp_enqueue_script( "wz-{$prefix}-tom-select" );
 
 		$defaults = array(
-			'action'   => $prefix . '_taxonomy_search_tom_select',
-			'nonce'    => wp_create_nonce( $prefix . '_taxonomy_search_tom_select' ),
 			'endpoint' => 'category',
 			'strings'  => array(
 				'no_results' => 'No results found for "%s"',

includes/admin/settings/js/taxonomy-suggest.js

@@ -328,69 +328,4 @@ public static function decrypt_api_key( $encrypted_key ) {
 
 		return $encrypted_key;
 	}
-
-
-	/**
-	 * Function to add an action to search for tags using Ajax.
-	 *
-	 * @since 1.0.0
-	 *
-	 * @return void
-	 */
-	public static function tags_search() {
-		if ( ! isset( $_REQUEST['tax'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Recommended
-			wp_die();
-		}
-
-		$taxonomy = sanitize_key( $_REQUEST['tax'] ); // phpcs:ignore WordPress.Security.NonceVerification.Recommended
-		$tax      = get_taxonomy( $taxonomy );
-		if ( ! empty( $taxonomy ) ) {
-			$tax = get_taxonomy( $taxonomy );
-			if ( ! $tax ) {
-				wp_die();
-			}
-
-			if ( ! current_user_can( $tax->cap->assign_terms ) ) {
-				wp_die();
-			}
-		}
-
-		$s = isset( $_REQUEST['q'] ) ? sanitize_text_field( wp_unslash( $_REQUEST['q'] ) ) : ''; // phpcs:ignore WordPress.Security.NonceVerification.Recommended
-
-		$comma = _x( ',', 'tag delimiter' );
-		if ( ',' !== $comma ) {
-			$s = str_replace( $comma, ',', $s );
-		}
-		if ( false !== strpos( $s, ',' ) ) {
-			$s = explode( ',', $s );
-			$s = $s[ count( $s ) - 1 ];
-		}
-		$s = trim( $s );
-
-		/** This filter has been defined in /wp-admin/includes/ajax-actions.php */
-		$term_search_min_chars = (int) apply_filters( 'term_search_min_chars', 2, $tax, $s );
-
-		/*
-		 * Require $term_search_min_chars chars for matching (default: 2)
-		 * ensure it's a non-negative, non-zero integer.
-		 */
-		if ( ( 0 === $term_search_min_chars ) || ( strlen( $s ) < $term_search_min_chars ) ) {
-			wp_die();
-		}
-
-		$results = get_terms(
-			array(
-				'taxonomy'   => $taxonomy,
-				'name__like' => $s,
-				'fields'     => 'names',
-				'hide_empty' => false,
-			)
-		);
-
-		echo wp_json_encode( $results );
-		wp_die();
-	}
 }
-
-// Add the tags search AJAX action.
-add_action( 'wp_ajax_' . Options_API::FILTER_PREFIX . '_tags_search', array( Options_API::class, 'tags_search' ) );