fix: improve error handling in test response encoding and writing

Author: tejzpr

calling/callcontrol_test.go

@@ -300,14 +300,16 @@ func TestLine(t *testing.T) {
 			switch r.Method {
 			case http.MethodPost:
 				w.WriteHeader(http.StatusOK)
-				json.NewEncoder(w).Encode(MobiusDeviceInfo{
+				if err := json.NewEncoder(w).Encode(MobiusDeviceInfo{
 					UserID:            "user-123",
 					KeepaliveInterval: 30,
 					Device: &DeviceType{
 						DeviceID: "device-abc",
 						URI:      "https://mobius/devices/device-abc",
 					},
-				})
+				}); err != nil {
+					t.Logf("Failed to encode response: %v", err)
+				}
 			case http.MethodDelete, http.MethodPut:
 				w.WriteHeader(http.StatusOK)
 			default:
@@ -349,9 +351,11 @@ func TestLine(t *testing.T) {
 				return
 			}
 			w.WriteHeader(http.StatusOK)
-			json.NewEncoder(w).Encode(MobiusDeviceInfo{
+			if err := json.NewEncoder(w).Encode(MobiusDeviceInfo{
 				Device: &DeviceType{DeviceID: "backup-device"},
-			})
+			}); err != nil {
+				t.Logf("Failed to encode response: %v", err)
+			}
 		}))
 		defer server.Close()
 
@@ -396,9 +400,11 @@ func TestLine(t *testing.T) {
 		server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 			if r.Method == http.MethodPost {
 				w.WriteHeader(http.StatusOK)
-				json.NewEncoder(w).Encode(MobiusDeviceInfo{
+				if err := json.NewEncoder(w).Encode(MobiusDeviceInfo{
 					Device: &DeviceType{DeviceID: "dev-1", URI: "https://test/dev-1"},
-				})
+				}); err != nil {
+					t.Logf("Failed to encode response: %v", err)
+				}
 				return
 			}
 			if r.Method == http.MethodDelete {

contents/contents_test.go

@@ -51,7 +51,9 @@ func TestDownload(t *testing.T) {
 		w.Header().Set("Content-Type", "application/pdf")
 		w.Header().Set("Content-Disposition", `attachment; filename="report.pdf"`)
 		w.WriteHeader(http.StatusOK)
-		w.Write(fileData)
+		if _, err := w.Write(fileData); err != nil {
+			t.Logf("Failed to write response: %v", err)
+		}
 	}))
 	defer server.Close()
 
@@ -83,7 +85,9 @@ func TestDownload_EmptyID(t *testing.T) {
 func TestDownload_APIError(t *testing.T) {
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		w.WriteHeader(http.StatusNotFound)
-		w.Write([]byte(`{"message":"not found"}`))
+		if _, err := w.Write([]byte(`{"message":"not found"}`)); err != nil {
+			t.Logf("Failed to write response: %v", err)
+		}
 	}))
 	defer server.Close()
 

encryption/encryption_test.go

@@ -943,7 +943,9 @@ func TestEndToEndDecrypt(t *testing.T) {
 	// 4. Decrypt the message
 
 	rawKey := make([]byte, 32)
-	rand.Read(rawKey)
+	if _, err := rand.Read(rawKey); err != nil {
+		t.Fatal(err)
+	}
 	keyURI := "kms://ciscospark.com/keys/e2e-test-key"
 
 	// Create JWE-encrypted message (simulating what Webex would produce)

recordings/recordings_test.go

@@ -443,7 +443,9 @@ func TestDownloadTranscript(t *testing.T) {
 		} else if r.URL.Path == "/download/transcript.txt" {
 			w.Header().Set("Content-Type", "text/plain")
 			w.WriteHeader(http.StatusOK)
-			w.Write(transcriptContent)
+			if _, err := w.Write(transcriptContent); err != nil {
+				t.Logf("Failed to write response: %v", err)
+			}
 		} else {
 			w.WriteHeader(http.StatusNotFound)
 		}