From 116039ce3697780d4d59b87b99e767fe4d47f905 Mon Sep 17 00:00:00 2001 From: "martin.kucin" Date: Wed, 11 Jun 2025 09:16:23 +0200 Subject: [PATCH 1/2] feat(deployment): Add 'successThreshold' and 'timeoutSeconds' for Probes --- CHANGELOG.md | 4 ++++ charts/weblate/Chart.yaml | 2 +- charts/weblate/README.md | 4 ++++ charts/weblate/templates/deployment.yaml | 8 ++++++-- charts/weblate/values.yaml | 4 ++++ 5 files changed, 19 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 940e3fca..7706a271 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.5.24 + +[FEATURE] Add `timeoutSeconds` and `successThreshold` for **livenessProbe** and **readinessProbe** [#583](https://github.com/WeblateOrg/helm/issues/583) + ## 0.5.23 [BUGFIX] Only trigger a reload of the pod, if the pod template change or the configuration changes [#557](https://github.com/WeblateOrg/helm/pull/557) diff --git a/charts/weblate/Chart.yaml b/charts/weblate/Chart.yaml index d70569cf..15de29b6 100644 --- a/charts/weblate/Chart.yaml +++ b/charts/weblate/Chart.yaml @@ -4,7 +4,7 @@ appVersion: 5.11.4.4 description: Weblate is a free web-based translation management system. name: weblate type: application -version: 0.5.23 +version: 0.5.24 home: https://weblate.org/ icon: https://s.weblate.org/cdn/weblate.svg maintainers: diff --git a/charts/weblate/README.md b/charts/weblate/README.md index 091d385c..cd279625 100644 --- a/charts/weblate/README.md +++ b/charts/weblate/README.md @@ -71,6 +71,8 @@ $ helm install my-release weblate/weblate | livenessProbe.failureThreshold | int | `10` | | | livenessProbe.initialDelaySeconds | int | `300` | | | livenessProbe.periodSeconds | int | `30` | | +| livenessProbe.successThreshold | int | `1` | | +| livenessProbe.timeoutSeconds | int | `5` | | | nameOverride | string | `""` | | | nodeSelector | object | `{}` | | | persistence.accessMode | string | `"ReadWriteOnce"` | | @@ -94,6 +96,8 @@ $ helm install my-release weblate/weblate | readinessProbe.failureThreshold | int | `2` | | | readinessProbe.initialDelaySeconds | int | `60` | | | readinessProbe.periodSeconds | int | `30` | | +| readinessProbe.successThreshold | int | `1` | | +| readinessProbe.timeoutSeconds | int | `5` | | | redis.architecture | string | `"standalone"` | | | redis.auth.enabled | bool | `true` | | | redis.auth.existingSecret | string | `""` | | diff --git a/charts/weblate/templates/deployment.yaml b/charts/weblate/templates/deployment.yaml index 8f2df197..249727a1 100644 --- a/charts/weblate/templates/deployment.yaml +++ b/charts/weblate/templates/deployment.yaml @@ -185,19 +185,23 @@ spec: {{- if .Values.livenessProbe }} livenessProbe: httpGet: - path: {{ $.Values.sitePrefix }}/healthz/ + path: {{ .Values.sitePrefix }}/healthz/ port: http failureThreshold: {{ .Values.livenessProbe.failureThreshold }} initialDelaySeconds: {{ .Values.livenessProbe.initialDelaySeconds }} + successThreshold: {{ .Values.livenessProbe.successThreshold }} + timeoutSeconds: {{ .Values.livenessProbe.timeoutSeconds }} periodSeconds: {{ .Values.livenessProbe.periodSeconds }} {{- end }} {{- if .Values.readinessProbe }} readinessProbe: httpGet: - path: {{ $.Values.sitePrefix }}/healthz/ + path: {{ .Values.sitePrefix }}/healthz/ port: http failureThreshold: {{ .Values.readinessProbe.failureThreshold }} initialDelaySeconds: {{ .Values.readinessProbe.initialDelaySeconds }} + successThreshold: {{ .Values.readinessProbe.successThreshold }} + timeoutSeconds: {{ .Values.readinessProbe.timeoutSeconds }} periodSeconds: {{ .Values.readinessProbe.periodSeconds }} {{- end }} volumeMounts: diff --git a/charts/weblate/values.yaml b/charts/weblate/values.yaml index 04cbc93b..c03095e4 100644 --- a/charts/weblate/values.yaml +++ b/charts/weblate/values.yaml @@ -182,13 +182,17 @@ affinity: {} livenessProbe: initialDelaySeconds: 300 periodSeconds: 30 + timeoutSeconds: 5 failureThreshold: 10 + successThreshold: 1 # Can be removed when running Weblate service without probes configured readinessProbe: initialDelaySeconds: 60 periodSeconds: 30 + timeoutSeconds: 5 failureThreshold: 2 + successThreshold: 1 postgresql: auth: From 8c2646dcdfa9302e95216629aef1c1a99479452d Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Wed, 11 Jun 2025 07:27:01 +0000 Subject: [PATCH 2/2] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- charts/weblate/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/weblate/README.md b/charts/weblate/README.md index cd279625..7cec26b6 100644 --- a/charts/weblate/README.md +++ b/charts/weblate/README.md @@ -1,6 +1,6 @@ # weblate -![Version: 0.5.23](https://img.shields.io/badge/Version-0.5.23-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 5.11.4.4](https://img.shields.io/badge/AppVersion-5.11.4.4-informational?style=flat-square) +![Version: 0.5.24](https://img.shields.io/badge/Version-0.5.24-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 5.11.4.4](https://img.shields.io/badge/AppVersion-5.11.4.4-informational?style=flat-square) Weblate is a free web-based translation management system.