Skip to content

feat(deployment): Add 'successThreshold' and 'timeoutSeconds' for Probes #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mart-Kuc merged 2 commits into from
Jun 11, 2025
Merged

feat(deployment): Add 'successThreshold' and 'timeoutSeconds' for Probes #584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
116039c
feat(deployment): Add 'successThreshold' and 'timeoutSeconds' for Probes
WildPigDeveloper Jun 11, 2025
8c2646d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.5.24

[FEATURE] Add `timeoutSeconds` and `successThreshold` for **livenessProbe** and **readinessProbe** [#583](https://github.com/WeblateOrg/helm/issues/583)

## 0.5.23

[BUGFIX] Only trigger a reload of the pod, if the pod template change or the configuration changes [#557](https://github.com/WeblateOrg/helm/pull/557)
Expand Down
2 changes: 1 addition & 1 deletion charts/weblate/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ appVersion: 5.11.4.4
description: Weblate is a free web-based translation management system.
name: weblate
type: application
version: 0.5.23
version: 0.5.24
home: https://weblate.org/
icon: https://s.weblate.org/cdn/weblate.svg
maintainers:
Expand Down
6 changes: 5 additions & 1 deletion charts/weblate/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# weblate

![Version: 0.5.23](https://img.shields.io/badge/Version-0.5.23-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 5.11.4.4](https://img.shields.io/badge/AppVersion-5.11.4.4-informational?style=flat-square)
![Version: 0.5.24](https://img.shields.io/badge/Version-0.5.24-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 5.11.4.4](https://img.shields.io/badge/AppVersion-5.11.4.4-informational?style=flat-square)

Weblate is a free web-based translation management system.

Expand Down Expand Up @@ -71,6 +71,8 @@ $ helm install my-release weblate/weblate
| livenessProbe.failureThreshold | int | `10` | |
| livenessProbe.initialDelaySeconds | int | `300` | |
| livenessProbe.periodSeconds | int | `30` | |
| livenessProbe.successThreshold | int | `1` | |
| livenessProbe.timeoutSeconds | int | `5` | |
| nameOverride | string | `""` | |
| nodeSelector | object | `{}` | |
| persistence.accessMode | string | `"ReadWriteOnce"` | |
Expand All @@ -94,6 +96,8 @@ $ helm install my-release weblate/weblate
| readinessProbe.failureThreshold | int | `2` | |
| readinessProbe.initialDelaySeconds | int | `60` | |
| readinessProbe.periodSeconds | int | `30` | |
| readinessProbe.successThreshold | int | `1` | |
| readinessProbe.timeoutSeconds | int | `5` | |
| redis.architecture | string | `"standalone"` | |
| redis.auth.enabled | bool | `true` | |
| redis.auth.existingSecret | string | `""` | |
Expand Down
8 changes: 6 additions & 2 deletions charts/weblate/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,19 +185,23 @@ spec:
{{- if .Values.livenessProbe }}
livenessProbe:
httpGet:
path: {{ $.Values.sitePrefix }}/healthz/
path: {{ .Values.sitePrefix }}/healthz/
port: http
failureThreshold: {{ .Values.livenessProbe.failureThreshold }}
initialDelaySeconds: {{ .Values.livenessProbe.initialDelaySeconds }}
successThreshold: {{ .Values.livenessProbe.successThreshold }}
timeoutSeconds: {{ .Values.livenessProbe.timeoutSeconds }}
periodSeconds: {{ .Values.livenessProbe.periodSeconds }}
{{- end }}
{{- if .Values.readinessProbe }}
readinessProbe:
httpGet:
path: {{ $.Values.sitePrefix }}/healthz/
path: {{ .Values.sitePrefix }}/healthz/
port: http
failureThreshold: {{ .Values.readinessProbe.failureThreshold }}
initialDelaySeconds: {{ .Values.readinessProbe.initialDelaySeconds }}
successThreshold: {{ .Values.readinessProbe.successThreshold }}
timeoutSeconds: {{ .Values.readinessProbe.timeoutSeconds }}
periodSeconds: {{ .Values.readinessProbe.periodSeconds }}
{{- end }}
volumeMounts:
Expand Down
4 changes: 4 additions & 0 deletions charts/weblate/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,13 +182,17 @@ affinity: {}
livenessProbe:
initialDelaySeconds: 300
periodSeconds: 30
timeoutSeconds: 5
failureThreshold: 10
successThreshold: 1

# Can be removed when running Weblate service without probes configured
readinessProbe:
initialDelaySeconds: 60
periodSeconds: 30
timeoutSeconds: 5
failureThreshold: 2
successThreshold: 1

postgresql:
auth:
Expand Down