feat: utilize language_regex from translation-finder#19523
Conversation
This allows it to propose languages exclusion.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9932201177
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
|
|
||
| def get_discovery_language_regex(result: DiscoveryResult) -> str: | ||
| return str(result.get("language_regex") or "^[^.]+$") |
There was a problem hiding this comment.
With the dependency still pinned to translation-finder==3.0 in pyproject.toml, the discovered results produced by that release do not include a language_regex field, so this helper always falls back to ^[^.]+$ in the real discovery/create flows. The new tests inject language_regex manually, but users choosing detected presets from discover() will still not get the source-language exclusion until the dependency is updated to a version that actually emits the field.
Useful? React with 👍 / 👎.
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
1 participant
This allows it to propose languages exclusion.