feat(checks): add accelerator key consistency check#19885
Open
fahadhewad wants to merge 1 commit into
Open
Conversation
Add an opt-in quality check that flags strings where the source and translation do not contain a matching accelerator key. It checks both the "&" (Qt/Windows) and "_" (GTK) markers, reporting a problem when the counts differ or the translation contains more than one. The check is disabled by default and is turned on per string or component with the "accelerators" flag, or skipped with "ignore-accelerators". Closes WeblateOrg#5962
fahadhewad
force-pushed
the
accelerator-check
branch
from
54b243a to
7d86160
Compare
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an opt in accelerators quality check, equivalent to msgfmt --check-accelerators, requested in #5962.
It flags a translated string when the source and translation doesnt contain a matching accelerator key.
The check is disabled by default and enabled per component with the accelerators flag.