Conversation
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 24cdfeffb2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3841 +/- ##
==========================================
+ Coverage 88.63% 88.79% +0.16%
==========================================
Files 68 71 +3
Lines 10019 10485 +466
Branches 858 907 +49
==========================================
+ Hits 8880 9310 +430
- Misses 846 873 +27
- Partials 293 302 +9 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 414fa5381c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Migrates hosted user authentication/synchronization from email-based SAML identifiers to persistent external IDs, introducing local storage for SAML identities and adding tooling to sync/audit hosted users.
Changes:
- Replace
/api/user/synchronization logic to useexternal_id-based SAML identity syncing. - Add
SamlIdentity(andExternalSyncState) models + migration, and register SAML identities in Django admin. - Switch SAML backend/config to persistent NameID and add management commands to sync/audit hosted users.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| weblate_web/views.py | Routes API user sync through new SAML identity sync helper and updates error handling paths. |
| weblate_web/tests.py | Adds coverage for external-id user sync, legacy linking, duplicate email ambiguity, and backend nameid extraction. |
| weblate_web/settings.py | Switches to custom SAML backend and configures persistent NameID + hosted sync endpoints. |
| weblate_web/saml.py | Implements SAML identity model syncing, legacy linking, and a custom djangosaml2 backend. |
| weblate_web/models.py | Adds SamlIdentity and ExternalSyncState models for persistent identity mapping and sync cursor storage. |
| weblate_web/migrations/0051_samlidentity_externalsyncstate.py | Creates DB tables/constraint for the new models. |
| weblate_web/management/commands/sync_hosted_users.py | Adds hosted→local user sync command using signed payloads and cursor persistence. |
| weblate_web/management/commands/audit_saml_users.py | Adds audit command to report duplicate-email risk prior to migration. |
| weblate_web/admin.py | Exposes SamlIdentity in Django admin for operational visibility. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a93ff3188b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e8eba77e55
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
nijel
force-pushed
the
user-sync
branch
2 times, most recently
from
4118061 to
b17a156
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b17a15688d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This also tries to consolidate the data.
This also tries to consolidate the data.
Companion to WeblateOrg/hosted#1560