Conversation
Now the data is migrated there is no need to maintain this.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes legacy “migration-era” SAML/user-sync functionality now that hosted-user identifiers are fully migrated, simplifying synchronization logic and associated operational tooling.
Changes:
- Removed legacy user-linking logic (username/email candidate matching) and the associated ambiguity error handling from SAML sync.
- Updated user sync tests and CRM tests to rely on
external_id/SamlIdentityrather than legacy payload formats. - Removed the
audit_saml_usersmanagement command and trimmed legacy troubleshooting output fromsync_hosted_users.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
weblate_web/tests.py |
Updates API/user-sync tests to use external_id + profile, and drops tests tied to legacy migration/audit behavior. |
weblate_web/saml.py |
Deletes legacy candidate-linking and ambiguity handling; makes external_id required for synchronization. |
weblate_web/management/commands/sync_hosted_users.py |
Removes legacy-candidate reporting and related imports/exception handling. |
weblate_web/management/commands/audit_saml_users.py |
Removes the legacy audit/cleanup command entirely. |
weblate_web/crm/views.py |
Drops handling for the removed ambiguity exception. |
weblate_web/crm/tests.py |
Updates CRM hosted-user linking tests to ensure existing users are linked via SamlIdentity. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3845 +/- ##
==========================================
+ Coverage 88.54% 88.56% +0.01%
==========================================
Files 72 71 -1
Lines 11126 10834 -292
Branches 1001 952 -49
==========================================
- Hits 9852 9595 -257
+ Misses 931 913 -18
+ Partials 343 326 -17 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now the data is migrated there is no need to maintain this.