fixed show_task function to check for empty list, added total and remaining tasks

Author: Webrowse

data/tasks.json

@@ -14,5 +14,9 @@
   {
     "desc": "abcdef",
     "completed": false
+  },
+  {
+    "desc": "this is to check complete and delete",
+    "completed": true
   }
 ]

src/commands/complete.rs

@@ -1,14 +1,22 @@
 use crate::storage::{load_tasks, save_tasks, show_tasks};
 
-pub fn complete(id: i32) {
+pub fn complete(id: u32) {
     let mut tasks = load_tasks();
-    if id == 0 || id > tasks.len() as i32 {
+    if id == 0 || id > tasks.len() as u32 {
         println!("Invalid task ID");
         show_tasks();
         return;
     }
     let index = (id - 1) as usize;
-    tasks[index].completed = true;
-    save_tasks(&tasks);
-    show_tasks();
+
+    if tasks[index].completed {
+        println!(r#"Task already completed: "{}""#, tasks[index].desc);
+    }
+    else{
+        tasks[index].completed = true;
+        save_tasks(&tasks);
+        println!(r#"Marked as complete: "{}" successfully."#, tasks[index].desc);
+        show_tasks();
+
+    }
 }

src/commands/delete.rs

@@ -1,8 +1,8 @@
 use crate::storage::{load_tasks, save_tasks, show_tasks};
 
-pub fn delete(id: i32) {
+pub fn delete(id: u32) {
     let mut tasks = load_tasks();
-    if id == 0 || id > tasks.len() as i32 {
+    if id == 0 || id > tasks.len() as u32 {
         println!("Invalid input, nothing was deleted, \nTry Again");
         show_tasks();
         return;
@@ -15,6 +15,6 @@ pub fn delete(id: i32) {
         .filter_map(|(i, task)| if i != index {Some(task)} else{None})
         .collect();
     save_tasks(&tasks);
-    println!(r#"Deleted Task: "{}" successfully"#, deleted);
+    println!(r#"Deleted Task: "{}" successfully."#, deleted);
     show_tasks();
 }

src/main.rs

@@ -20,8 +20,8 @@ struct Cli {
 enum Commands {
     Add { desc: String },
     List,
-    Complete { id: i32 },
-    Delete { id: i32 },
+    Complete { id: u32 },
+    Delete { id: u32 },
 }
 
 fn main() {

src/storage/file.rs

@@ -30,8 +30,18 @@ pub fn save_tasks(tasks: &Vec<Task>) {
 
 pub fn show_tasks() {
     let tasks = load_tasks();
+    if tasks.is_empty() {
+        println!("No task found.");
+        return;
+    }
     for (i, task) in tasks.iter().enumerate() {
         let status = if task.completed { "[x]" } else { "[ ]" };
-        println!("{} {} {} ", i + 1, status, task.desc);
+        println!("{:>3}. {:>3} {} ", i + 1, status, task.desc);
     }
+    let total = tasks.iter().filter(|t| !t.completed).count();
+    println!(
+        "\nTotal Tasks: {} | Remaining Tasks: {}\n",
+        tasks.iter().len(),
+        total
+    );
 }