fix: session restart state handling improvements#19
Open
lzw-git-all wants to merge 1 commit into
Open
Conversation
Problem 1: SDK session ID persists after restart - After daemon crash/restart, sdkSessionId still points to stale server-side session - Resume causes SDK to continue processing old task instead of new request - Fix: Clear sdkSessionId on startup, backup to previousSdkSessionId Problem 2: Permission timeout uses wrong context - sharedCtx.lastContextToken gets overwritten by concurrent messages - Timeout message sent to wrong user/context - Fix: Store contextToken/fromUserId in PendingPermission itself Also: Protect code blocks when splitting long messages
lzw-git-all
force-pushed
the
fix/session-restart-state-clearing
branch
from
4071596 to
dc6c63f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two issues related to session restart:
Problem 1: SDK session ID persists after restart
Problem 2: Permission timeout uses wrong context
Also includes: Code block protection when splitting long messages