fix(openai): avoid long Codex burst cooldown#2264
Closed
ronger-x wants to merge 1 commit intoWei-Shaw:mainfrom
Closed
fix(openai): avoid long Codex burst cooldown#2264ronger-x wants to merge 1 commit intoWei-Shaw:mainfrom
ronger-x wants to merge 1 commit intoWei-Shaw:mainfrom
Conversation
Contributor
|
Thank you for your contribution! Before we can merge this PR, we need you to sign our Contributor License Agreement (CLA). To sign, please reply with the following comment:
You only need to sign once — it will be valid for all your future contributions to this project. I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rate_limit_reset_atcan be retried when the normal scheduler has no viable account.Root Cause
Codex 429 responses can include long reset windows even when the corresponding
used_percentvalues are below 100. The previous fallback selected the maximum reset value anyway, which could turn a short burst/RPM cooldown into a multi-hour account block. Once persisted, the main scheduler filtered those accounts before requests could reach the success-header cleanup path.Validation
cd backend && go test -tags=unit ./internal/service -run "TestCalculateOpenAI429ResetTime|TestOpenAISelectAccount"