fix(openai): preserve JSON instructions in Codex OAuth input#3337
Open
ddnio wants to merge 1 commit into
Open
Conversation
Contributor
|
Thank you for your contribution! Before we can merge this PR, we need you to sign our Contributor License Agreement (CLA). To sign, please reply with the following comment:
You only need to sign once — it will be valid for all your future contributions to this project. I have read the CLA Document and I hereby sign the CLA 欧阳丹 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inputitems withrole: "system"torole: "developer"instead of dropping theminstructionsfor the ChatGPT internal Codex endpointjsoninstruction is in the system messageWhy
The previous transform removed system messages from
inputafter copying their text intoinstructions. That can break OpenAI Responses JSON object validation because the Responses API requires the wordjsonto appear in the input messages whentext.format.typeisjson_object.Keeping the message in
inputasdeveloperpreserves the JSON-mode instruction while still avoiding the unsupportedsystemrole for the Codex OAuth upstream.Validation
go test ./internal/service -run 'TestApplyCodexOAuthTransform|TestExtractSystemMessagesFromInput|TestIsInstructionsEmpty' -count=1go test ./internal/service -count=1git diff --check upstream/main...HEAD