Quirks of nes.hexpat with famiclones and miscellaneous fixes#467
Merged
Conversation
Add many changes to nes.hexpat
Add credit to ne.hexpat
C3pa
reviewed
Dec 17, 2025
Contributor
There was a problem hiding this comment.
These changes look unrelated.
Contributor
Author
There was a problem hiding this comment.
Yes, I also fixed a bug with the PE pattern that I didn't notice until after the previous pull request was already merged, sorry. Forgot to mention it.
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Miscellaneous ROMs were added (any ROM after the machine code and misc. data; most famous ones are the PlayChoice-10 ROMs).
One of them was found in a file with the PRG ROM (machine code) bigger than the size that the format can normally store. I tried as much as I could to stick to how the NES 2.0 extension handles that and got very close, but was ultimately not able to do it. I included a hacked together approach that works.
Mappers 83 to 92 were added, as well as 256 (VTxx famiclones), 426 (VT369 ones with a misc. ROM), 424 (variant with the aforementioned large PRG ROM), 355 (has the third misc. ROM), 594 (historically significant due to the recent talks about its console Rinco Talkman), 187 (seemingly the basis for it) and 595 (the only other mapper with a similar number).
Proper labels were added for some mapper names missing them, and so were mapper designations 0 and 1. Mapper 51's submapper was also added.
There's various fixes of odd indenting and coding as well.