More accurate variable declarations on nes.hexpat, add n64, gen, and gbx.hexpat#477
Merged
Conversation
Contributor
Author
|
nes.hexpat currently fails. This was shown in the last commit, but since in the first commit ttf.hexpat was failing instead (for some reason), I assumed the same thing was happening there. Will investigate later. |
WerWolv
reviewed
Jan 11, 2026
| (1): submapper = "No bus conflicts"; | ||
| (2): submapper = "AND-type bus conflicts"; | ||
| } | ||
| } |
Owner
There was a problem hiding this comment.
You accidentally removed a } here, that's why the unit tests are failing
Owner
|
Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many variables in nes.hexpat were given more proper names and lengths (a more glaring example is "VT3xx" in ExtendedConsoleType; when I did this, general knowledge of the VT3xx line was still unclear, but now it's common knowledge that VT36x is the usual standard NES res and VT38x is high-res, and the latter does not have support in the format yet, so it's clearly VT36x). The constant FILLED_NES2_FLAGS was properly applied in all places that used it. The TxROM designation was more thoroughly elaborated with its more common types.
DefaultExpansionDeviceType was added, primarily to highlight which ROMs use the device "multicart".
I have also added patterns for N64 and Mega Drive ROMs, as well as the fanmade GBX footer for GameBoy ROMs (similar to iNES/NES2.0 in the nes pattern).