patterns/mifare: Add MIFARE Classic 1K and 4K patterns and test data#498
Open
Bananz0 wants to merge 2 commits intoWerWolv:masterfrom
Open
patterns/mifare: Add MIFARE Classic 1K and 4K patterns and test data#498Bananz0 wants to merge 2 commits intoWerWolv:masterfrom
Bananz0 wants to merge 2 commits intoWerWolv:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive pattern definitions for MIFARE Classic 1K and 4K NFC cards, implementing ISO/IEC 14443-3 Type A format specifications with detailed validation logic. The patterns are placed in a new patterns/mifare/ directory, following good organization practices for related formats.
Changes:
- Added MIFARE Classic 1K pattern file with struct definitions for manufacturer block, data blocks, sector trailers, and validation functions for BCC, SAK, and access bits
- Added MIFARE Classic 4K pattern file supporting both small (64-byte) and large (256-byte) sectors with comprehensive validation
- Added synthetic test binaries for both 1K (1024 bytes) and 4K (4096 bytes) formats to enable automated testing
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| patterns/mifare/mifare-1k.hexpat | Pattern definition for MIFARE Classic 1K cards with 16 sectors, validation functions, and detailed documentation |
| patterns/mifare/mifare-4k.hexpat | Pattern definition for MIFARE Classic 4K cards with 32 small + 8 large sectors, validation logic for BCC/SAK/access bits |
| tests/patterns/test_data/mifare-1k.hexpat.bin | Binary test data for 1K variant following test data naming conventions |
| tests/patterns/test_data/mifare-4k.hexpat.bin | Binary test data for 4K variant following test data naming conventions |
| README.md | Added two entries to pattern table documenting the new MIFARE Classic patterns |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grouped MIFARE Classic patterns into their own folder
Adds: