evaluator: Fix conditional union size (#153)

* tests: Added test case for conditional union

* pattern/fix: Fix conditional union size

---------

Co-authored-by: Dmitri Zhabinski <zhabinski@protonmail.com>

Author: zhabinski

lib/source/pl/core/ast/ast_node_union.cpp

@@ -18,14 +18,19 @@ namespace pl::core::ast {
         evaluator->alignToByte();
         auto pattern = std::make_shared<ptrn::PatternUnion>(evaluator, evaluator->getReadOffset(), 0, getLocation().line);
 
-        size_t size = 0;
         std::vector<std::shared_ptr<ptrn::Pattern>> memberPatterns;
         u64 startOffset = evaluator->getReadOffset();
 
         pattern->setSection(evaluator->getSectionId());
 
         evaluator->pushScope(pattern, memberPatterns);
         ON_SCOPE_EXIT {
+            size_t size = 0;
+            for (auto &memberPattern : memberPatterns) {
+                size = std::max(memberPattern->getSize(), size);
+            }
+            pattern->setSize(size);
+
             evaluator->setReadOffset(startOffset + size);
             if (evaluator->isReadOrderReversed())
                 pattern->setAbsoluteOffset(evaluator->getReadOffset());
@@ -54,11 +59,9 @@ namespace pl::core::ast {
                     }
                 }
 
-                size = std::max(memberPattern->getSize(), size);
                 memberPattern->setSection(evaluator->getSectionId());
                 memberPatterns.push_back(std::move(memberPattern));
             }
-            pattern->setSize(size);
 
             if (evaluator->getCurrentControlFlowStatement() == ControlFlowStatement::Return)
                 break;

tests/include/test_patterns/test_pattern_unions.hpp

@@ -34,7 +34,7 @@ namespace pl::test {
             return R"(
                 union TestUnion {
                     s32 array[2];
-                    u128 variable;
+                    if ( true ) { u128 variable; }
                 };
 
                 TestUnion testUnion @ 0x200;