Skip to content

Update libfmt to 11.2.0#163

Merged
WerWolv merged 2 commits into
WerWolv:masterfrom
henri-gasc:master
May 9, 2025
Merged

Update libfmt to 11.2.0#163
WerWolv merged 2 commits into
WerWolv:masterfrom
henri-gasc:master

Conversation

@henri-gasc
Copy link
Copy Markdown
Contributor

As stated in the libfmt release note:
Deprecated fmt::localtime in favor of std::localtime.

This also fixes part of WerWolv/ImHex#2225

@WerWolv
Copy link
Copy Markdown
Owner

WerWolv commented May 9, 2025

Thank you! Is fmt::gmtime affected as well? Kinda weird that they'd only deprecate one and not the other

@henri-gasc
Copy link
Copy Markdown
Contributor Author

From what I can see, it is not impacted.
They probably deprecated localtime and not gmtime, because the latter is not thread-safe in std (as in, This function may not be thread-safe. as opposed to This function may not be thread-safe. The [Microsoft CRT](https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/localtime-localtime32-localtime64) implementation is thread-safe., but yeah, kinda weird

@WerWolv
Copy link
Copy Markdown
Owner

WerWolv commented May 9, 2025

Well we're using libstdc++, not MSVC so who knows if it is in our case. I just went ahead and replaced gmtime as well just for consistency. (Also fixed the build issue due to the different interface)

@WerWolv WerWolv merged commit a59aa47 into WerWolv:master May 9, 2025
4 checks passed
lawm pushed a commit to lawm/PatternLanguage that referenced this pull request Mar 13, 2026
* Update libfmt to 11.2.0

* Fix calling of std::localtime and replace fmt::gmtime with std::gmtime as well

---------

Co-authored-by: Nik <werwolv98@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants