Address PR review: fix slackbot CI smoke-test + harden charge receiver

- slackbot-ci: stub SocketModeRequest/Response on the slack_sdk stub modules
  (import was failing with 'cannot import name SocketModeRequest') and
  provision /app/logs so the module-level mkdir doesn't fail on the runner.
- slack_bot: require CHARGE_RELAY_TOKEN before starting the charge-dashboard
  receiver; the port is host-published and must not accept unauthenticated POSTs.
- docker-compose.lan-sender-test: set POSTGRES_DSN to the timescaledb service
  (default DSN points at localhost, which is the base container here).
- websocket_bridge: aclose the Redis client via try/finally so a failing set
  doesn't leak the connection.
- redis_utils: correct get_sync_client docstring (default retries=5, ~8s).

Author: wfr-data-acquisition

.github/workflows/slackbot-ci.yml

@@ -38,6 +38,9 @@ jobs:
           SLACK_APP_TOKEN: xapp-test-000000000000
           SLACK_BOT_TOKEN: xoxb-test-000000000000
         run: |
+          # slack_bot.py creates /app/logs at module import; the CI user can't
+          # write under / by default, so provision it before the smoke-test.
+          sudo mkdir -p /app/logs && sudo chmod 777 /app/logs
           python - <<'EOF'
           import importlib, sys, types
 
@@ -56,6 +59,13 @@ jobs:
               socket_mode_request_listeners = []
           sm_mod.SocketModeClient = _FakeSMC  # type: ignore[attr-defined]
 
+          # slack_bot imports SocketModeRequest/Response from these submodules at
+          # module load; the stubs need the attributes or the import raises.
+          sys.modules["slack_sdk.socket_mode.request"].SocketModeRequest = type(  # type: ignore[attr-defined]
+              "SocketModeRequest", (), {})
+          sys.modules["slack_sdk.socket_mode.response"].SocketModeResponse = type(  # type: ignore[attr-defined]
+              "SocketModeResponse", (), {})
+
           import requests as _req
           _orig_get = _req.get
           def _no_net(*a, **kw): raise RuntimeError("network disabled in CI")

server/installer/slackbot/slack_bot.py

@@ -847,11 +847,16 @@ def process_events(client: SocketModeClient, req: SocketModeRequest):
     # behind Cloudflare Zero Trust). Posts one self-updating Slack message per session.
     try:
         from charge_dashboard import ChargeDashboard, start_http_server
+        # Require a shared token: the receiver port is published on the host and
+        # accepting unauthenticated POSTs would let anyone reach it post to Slack.
+        token = (os.environ.get("CHARGE_RELAY_TOKEN") or "").strip()
+        if not token:
+            raise RuntimeError("CHARGE_RELAY_TOKEN not set — refusing to start an unauthenticated receiver")
         _charge_dash = ChargeDashboard(web_client, DEFAULT_CHANNEL)
         start_http_server(
             _charge_dash,
             port=int(os.environ.get("CHARGE_DASHBOARD_PORT", "9099")),
-            token=os.environ.get("CHARGE_RELAY_TOKEN") or None,
+            token=token,
         )
     except Exception as e:
         print(f"⚠️ Charge dashboard not started: {e}")

universal-telemetry-software/deploy/docker-compose.lan-sender-test.yml

@@ -19,6 +19,7 @@ services:
       - UDP_PORT=5005
       - TCP_PORT=5006
       - REDIS_URL=redis://base-redis:6379/0
+      - POSTGRES_DSN=postgresql://wfr:password@timescaledb:5432/wfr
       - TIMESCALE_TABLE=wfr26
       - ENABLE_TIMESCALE_LOGGING=true
     depends_on:

universal-telemetry-software/src/redis_utils.py

@@ -19,9 +19,9 @@ def get_sync_client(url: str, retries: int = 5, backoff: float = 1.0):
 
     Args:
         url: Redis connection URL.
-        retries: Maximum connection attempts before giving up (default 10).
+        retries: Maximum connection attempts before giving up (default 5).
         backoff: Seconds to wait between retries, multiplied by 1.5 each attempt.
-                 With default values: ~25s total (1+1.5+2.25+3.375+...).
+                 With default values: ~8s total sleep (1+1.5+2.25+3.375).
     """
     client = redis.from_url(url)
     attempt = 0

universal-telemetry-software/src/websocket_bridge.py

@@ -66,8 +66,10 @@ async def _publish_client_count() -> None:
     """Publish the current WebSocket client count for the HTTP health snapshot."""
     try:
         r = redis.from_url(REDIS_URL)
-        await r.set(REDIS_WS_CLIENTS_KEY, json.dumps(_client_count_snapshot()), ex=10)
-        await r.aclose()
+        try:
+            await r.set(REDIS_WS_CLIENTS_KEY, json.dumps(_client_count_snapshot()), ex=10)
+        finally:
+            await r.aclose()
     except Exception as e:
         logger.debug("Could not publish WebSocket client count: %s", e)