Uploader better error display, handling

Author: haoruizhou

server/installer/file-uploader/app.py

@@ -553,12 +553,13 @@ def on_progress(sent: int, total: int) -> None:
                 pass
 
         def worker():
-            streamer = CANTimescaleStreamer(
-                postgres_dsn=POSTGRES_DSN,
-                table=season.lower(),
-                dbc_path=dbc_temp_path,
-            )
+            streamer = None
             try:
+                streamer = CANTimescaleStreamer(
+                    postgres_dsn=POSTGRES_DSN,
+                    table=season.lower(),
+                    dbc_path=dbc_temp_path,
+                )
                 asyncio.run(
                     streamer.stream_multiple_csvs(
                         file_data=file_data,
@@ -568,14 +569,16 @@ def worker():
                 )
             except Exception as e:
                 error_logger.error(traceback.format_exc())
-                PROGRESS[task_id]["msg"]  = f"Error: {e}"
-                PROGRESS[task_id]["done"] = True
+                PROGRESS[task_id]["msg"]   = f"Error: {e}"
+                PROGRESS[task_id]["error"] = str(e)
+                PROGRESS[task_id]["done"]  = True
                 slack.fail(str(e))
             finally:
-                try:
-                    streamer.close()
-                except Exception as e:
-                    print("error closing streamer", e)
+                if streamer:
+                    try:
+                        streamer.close()
+                    except Exception as e:
+                        print("error closing streamer", e)
                 if dbc_temp_path and os.path.exists(dbc_temp_path):
                     try:
                         os.unlink(dbc_temp_path)

server/installer/file-uploader/static/index.js

@@ -165,6 +165,9 @@ function handleProgress(task_id, fileName, season) {
 	canSubmit = false;
 	localStorage.setItem(STORAGE_KEY, task_id);
 	setDropZoneState("uploading");
+	const errBox = document.getElementById("upload-error-box");
+	if (errBox) errBox.style.display = "none";
+	document.getElementById("progress-bar").style.background = "";
 
 	// Show safe-to-close banner immediately
 	if (fileName || season) showSafeToCloseBanner(fileName, season);
@@ -194,9 +197,24 @@ function handleProgress(task_id, fileName, season) {
 			localStorage.removeItem(STORAGE_KEY);
 			hideSafeToCloseBanner();
 
-			document.getElementById("progress-bar_pct").innerText = "Done ✓";
-			document.getElementById("progress-bar_count").innerText =
-				data.total ? `${data.total.toLocaleString()} rows written` : "Complete";
+			if (data.error) {
+				document.getElementById("progress-bar_pct").innerText = "Failed ✗";
+				document.getElementById("progress-bar").style.background = "#b91c1c";
+				document.getElementById("progress-bar_count").innerText = "";
+				const errBox = document.getElementById("upload-error-box") || (() => {
+					const el = document.createElement("div");
+					el.id = "upload-error-box";
+					el.style.cssText = "margin-top:10px;padding:10px 14px;background:#450a0a;border:1px solid #b91c1c;border-radius:6px;color:#fca5a5;font-size:0.85em;white-space:pre-wrap;word-break:break-word;";
+					document.querySelector(".progress-bar_parent").after(el);
+					return el;
+				})();
+				errBox.innerText = "❌ Upload failed:\n" + data.error;
+				errBox.style.display = "block";
+			} else {
+				document.getElementById("progress-bar_pct").innerText = "Done ✓";
+				document.getElementById("progress-bar_count").innerText =
+					data.total ? `${data.total.toLocaleString()} rows written` : "Complete";
+			}
 
 			["drop_zone-input", "season-select", "dbc-select", "dbc-input"].forEach((id) => {
 				const el = document.getElementById(id);