Dev

[haoruizhou]

No description provided.

[chatgpt-codex-connector]

💡 Codex Review

data-acquisition/universal-telemetry-software/deploy/docker-compose.macbook-base.yml

Line 43 in 64c80ea

- ${DBC_HOST_PATH:-./example.dbc}:/app/active.dbc:ro

Fix default DBC bind path for MacBook stack

The telemetry volume defaults to ${DBC_HOST_PATH:-./example.dbc}, but this compose file lives in deploy/ while the checked-in DBC is at universal-telemetry-software/example.dbc. With the documented default .env.macbook, Docker resolves ./example.dbc to deploy/example.dbc (missing), so the telemetry container fails to start unless users manually override DBC_HOST_PATH.

---

data-acquisition/universal-telemetry-software/deploy/timescaledb_init_macbook.sql

Line 61 in 64c80ea

SELECT create_season_table('WFR26test');

Create the same Timescale table name the app writes

This initializer creates WFR26test, but the new MacBook compose config writes to TIMESCALE_TABLE=${TIMESCALE_TABLE:-WFR26test}_base (default WFR26test_base). TimescaleBridge issues ALTER TABLE/INSERT on the configured table and does not bootstrap missing base tables, so the default stack hits relation-not-found errors and never persists telemetry.

---

data-acquisition/universal-telemetry-software/setup-socketcan.sh

Lines 83 to 84 in 64c80ea

	echo -e " 4. Start the stack: docker compose -f deploy/docker-compose.rpi-base.yml up -d"
	echo -e " 5. Check role: docker compose -f deploy/docker-compose.rpi-base.yml logs telemetry | grep Role"

Keep car SocketCAN setup steps from launching base role

This script is for the car RPi, but the updated next-step command now starts docker-compose.rpi-base.yml, whose telemetry service is hardcoded to ROLE=base. Following these instructions on a car device starts the wrong role (and conflicts with the car systemd path), so expected car-side CAN transmit behavior does not come up.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".