Skip to content

Commit 003e7aa

Browse files
committed
chore: hard coding strings is bad
1 parent 646e945 commit 003e7aa

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

app/src/main/java/tech/akpmakes/android/taskkeeper/MainActivity.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ protected void onActivityResult(int requestCode, int resultCode, Intent data) {
177177
WhenEvent evt = new WhenEvent(data);
178178

179179
if(evt.getName().length() == 0) {
180-
Snackbar.make(findViewById(android.R.id.content), "Your task could not be saved. Task name is required.",
180+
Snackbar.make(findViewById(android.R.id.content), R.string.snackbar_save_error_name,
181181
Snackbar.LENGTH_LONG).show();
182182
return;
183183
}
@@ -189,10 +189,10 @@ protected void onActivityResult(int requestCode, int resultCode, Intent data) {
189189
mDBQuery.getRef().push().setValue(evt);
190190
}
191191

192-
Snackbar.make(findViewById(android.R.id.content), "Task saved successfully!",
192+
Snackbar.make(findViewById(android.R.id.content), R.string.snackbar_save_success,
193193
Snackbar.LENGTH_LONG).show();
194194
} else {
195-
Snackbar.make(findViewById(android.R.id.content), "Your task could not be saved. Please try again.",
195+
Snackbar.make(findViewById(android.R.id.content), R.string.snackbar_save_error,
196196
Snackbar.LENGTH_LONG).show();
197197
}
198198
}

app/src/main/res/values/strings.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,4 +80,7 @@
8080
<string name="snackbar_task_reset">Task reset successfully!</string>
8181
<string name="snackbar_task_deleted">Task deleted successfully!</string>
8282
<string name="snackbar_undo_action">UNDO</string>
83+
<string name="snackbar_save_success">Task saved successfully!</string>
84+
<string name="snackbar_save_error">Your task could not be saved. Please try again.</string>
85+
<string name="snackbar_save_error_name">Your task could not be saved. Task name is required.</string>
8386
</resources>

0 commit comments

Comments
 (0)