Skip to content

Commit 4afaa18

Browse files
authored
ci(play): fix gradlew exec bit and align store password secret name (#42)
Two fixes for the failing 'Publish to Google Play' run (#41 follow-up): 1. gradlew was committed with mode 100644, so the runner refused to execute it ('./gradlew: Permission denied', exit 126). Set the execute bit in the index via 'git update-index --chmod=+x gradlew' so checkouts on Linux runners can invoke it directly. 2. The workflow read the store password from a secret named ANDROID_KEYSTORE_PASSWORD, but the matching Gradle property in app/build.gradle is ANDROID_STORE_PASSWORD. Renamed the workflow reference + README documentation to ANDROID_STORE_PASSWORD so all five secrets line up 1:1 with the Gradle property names.
1 parent 1efc025 commit 4afaa18

3 files changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/publish-play.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ jobs:
5959
env:
6060
ORG_GRADLE_PROJECT_ANDROID_SIGNING_KEY: ${{ secrets.ANDROID_KEY_ALIAS }}
6161
ORG_GRADLE_PROJECT_ANDROID_KEY_PASSWORD: ${{ secrets.ANDROID_KEY_PASSWORD }}
62-
ORG_GRADLE_PROJECT_ANDROID_STORE_PASSWORD: ${{ secrets.ANDROID_KEYSTORE_PASSWORD }}
62+
ORG_GRADLE_PROJECT_ANDROID_STORE_PASSWORD: ${{ secrets.ANDROID_STORE_PASSWORD }}
6363
ORG_GRADLE_PROJECT_ANDROID_KEY_FILE: ${{ env.ANDROID_KEY_FILE }}
6464
run: ./gradlew :app:bundleProdRelease --no-daemon --stacktrace
6565

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Developer API.
2525
| Secret | Purpose |
2626
| --- | --- |
2727
| `ANDROID_KEYSTORE_BASE64` | Base64-encoded upload keystore (`base64 -w0 upload.keystore`) |
28-
| `ANDROID_KEYSTORE_PASSWORD` | Keystore (store) password |
28+
| `ANDROID_STORE_PASSWORD` | Keystore (store) password |
2929
| `ANDROID_KEY_ALIAS` | Key alias inside the keystore |
3030
| `ANDROID_KEY_PASSWORD` | Password for the key entry |
3131
| `PLAY_SERVICE_ACCOUNT_JSON` | Full JSON for a Google Play service account with `Release Manager` permissions |

gradlew

100644100755
File mode changed.

0 commit comments

Comments
 (0)