fix: SessionPersistenceService 트랜잭션 내 엔티티 재조회 및 중복 실행 방지

fix: SessionPersistenceService 트랜잭션 내 엔티티 재조회 및 중복 실행 방지

Author: Boyeon-Shin

src/main/java/io/wisoft/prepair/prepair_api/interview/answer/event/AllAnalysisCompletedHandler.java

@@ -199,7 +199,7 @@ private FinalFeedbackData buildFinalData(
     private void completeSession(InterviewSession session, FinalFeedbackData data, FinalFeedbackResult finalResult) {
         UUID sessionId = session.getId();
 
-        sessionPersistenceService.saveCompletedSession(session, data.finalScore(), finalResult.finalFeedback());
+        sessionPersistenceService.saveCompletedSession(sessionId, data.finalScore(), finalResult.finalFeedback());
 
         FinalFeedbackResponse response = new FinalFeedbackResponse(
                 sessionId,
@@ -219,7 +219,7 @@ private void failSession(UUID answerId, String message) {
         if (answer == null || answer.getInterviewQuestion().getInterviewSession() == null) return;
 
         InterviewSession session = answer.getInterviewQuestion().getInterviewSession();
-        sessionPersistenceService.saveFailedSession(session);
+        sessionPersistenceService.saveFailedSession(session.getId());
 
         sseEmitterManager.send(session.getId(), "analysis-failed", Map.of("message", message));
         sseEmitterManager.complete(session.getId());

src/main/java/io/wisoft/prepair/prepair_api/interview/session/service/SessionPersistenceService.java

@@ -1,26 +1,41 @@
 package io.wisoft.prepair.prepair_api.interview.session.service;
 
 import io.wisoft.prepair.prepair_api.interview.session.entity.InterviewSession;
+import io.wisoft.prepair.prepair_api.interview.session.entity.SessionStatus;
 import io.wisoft.prepair.prepair_api.interview.session.repository.SessionRepository;
 import lombok.RequiredArgsConstructor;
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
 
+import java.util.UUID;
+
 @Service
 @RequiredArgsConstructor
 public class SessionPersistenceService {
 
     private final SessionRepository sessionRepository;
 
     @Transactional
-    public void saveCompletedSession(InterviewSession session, int finalScore, String finalFeedback) {
+    public void saveCompletedSession(UUID sessionId, int finalScore, String finalFeedback) {
+        InterviewSession session = sessionRepository.findById(sessionId)
+                .orElseThrow(() -> new IllegalArgumentException("존재하지 않는 세션입니다."));
+
+        if (session.getStatus() == SessionStatus.COMPLETED) {
+            return;
+        }
+
         session.complete(finalScore, finalFeedback);
-        sessionRepository.save(session);
     }
 
     @Transactional
-    public void saveFailedSession(InterviewSession session) {
+    public void saveFailedSession(UUID sessionId) {
+        InterviewSession session = sessionRepository.findById(sessionId)
+                .orElseThrow(() -> new IllegalArgumentException("존재하지 않는 세션입니다."));
+
+        if (session.getStatus() != SessionStatus.IN_PROGRESS) {
+            return;
+        }
+
         session.fail();
-        sessionRepository.save(session);
     }
 }