autofix remaining issues

Author: slax57

examples/crm/src/deals/DealEdit.tsx

@@ -45,7 +45,7 @@ export const DealEdit = ({ open, id }: { open: boolean; id?: string }) => {
                 },
             }}
         >
-            {!!id ? (
+            {id ? (
                 <EditBase
                     id={id}
                     mutationMode="pessimistic"

examples/crm/src/deals/DealShow.tsx

@@ -54,7 +54,7 @@ export const DealShow = ({ open, id }: { open: boolean; id?: string }) => {
             }}
         >
             <DialogContent sx={{ padding: 0 }}>
-                {!!id ? (
+                {id ? (
                     <ShowBase id={id}>
                         <DealShowContent handleClose={handleClose} />
                     </ShowBase>

examples/crm/src/layout/Header.tsx

@@ -26,13 +26,13 @@ const Header = () => {
     const location = useLocation();
 
     let currentPath: string | boolean = '/';
-    if (!!matchPath('/', location.pathname)) {
+    if (matchPath('/', location.pathname)) {
         currentPath = '/';
-    } else if (!!matchPath('/contacts/*', location.pathname)) {
+    } else if (matchPath('/contacts/*', location.pathname)) {
         currentPath = '/contacts';
-    } else if (!!matchPath('/companies/*', location.pathname)) {
+    } else if (matchPath('/companies/*', location.pathname)) {
         currentPath = '/companies';
-    } else if (!!matchPath('/deals/*', location.pathname)) {
+    } else if (matchPath('/deals/*', location.pathname)) {
         currentPath = '/deals';
     } else {
         currentPath = false;

examples/crm/src/providers/commons/activity.ts

@@ -22,14 +22,14 @@ export async function getActivityLog(
     companyId?: Identifier,
     salesId?: Identifier
 ) {
-    let companyFilter = {} as any;
+    const companyFilter = {} as any;
     if (companyId) {
         companyFilter.id = companyId;
     } else if (salesId) {
         companyFilter['sales_id@in'] = `(${salesId})`;
     }
 
-    let filter = {} as any;
+    const filter = {} as any;
     if (companyId) {
         filter.company_id = companyId;
     } else if (salesId) {
@@ -85,7 +85,7 @@ async function getNewContactsAndNotes(
         sort: { field: 'first_seen', order: 'DESC' },
     });
 
-    let recentContactNotesFilter = {} as any;
+    const recentContactNotesFilter = {} as any;
     if (filter.sales_id) {
         recentContactNotesFilter.sales_id = filter.sales_id;
     }
@@ -135,7 +135,7 @@ async function getNewDealsAndNotes(
         sort: { field: 'created_at', order: 'DESC' },
     });
 
-    let recentDealNotesFilter = {} as any;
+    const recentDealNotesFilter = {} as any;
     if (filter.sales_id) {
         recentDealNotesFilter.sales_id = filter.sales_id;
     }

examples/crm/src/providers/commons/getContactAvatar.spec.ts

@@ -8,7 +8,6 @@
 import { Contact } from '../../types';
 import { getContactAvatar, hash } from './getContactAvatar';
 
-// eslint-disable-next-line no-global-assign
 import { webcrypto } from 'node:crypto';
 
 Object.defineProperty(globalThis, 'crypto', {

examples/crm/src/tasks/Task.tsx

@@ -160,7 +160,7 @@ export const Task = ({
                     </ListItemIcon>
                     <ListItemText
                         sx={{
-                            textDecoration: !!task.done_date
+                            textDecoration: task.done_date
                                 ? 'line-through'
                                 : 'none',
                         }}

examples/data-generator/src/finalize.ts

@@ -4,7 +4,7 @@ import { weightedBoolean } from './utils';
 export default function (db: Db) {
     // set latest purchase date
     db.orders.forEach(order => {
-        let customer = db.customers[order.customer_id];
+        const customer = db.customers[order.customer_id];
         if (
             !customer.latest_purchase ||
             customer.latest_purchase < order.date
@@ -64,7 +64,7 @@ export default function (db: Db) {
 
     // add 'reviewer' group
     db.reviews.forEach(review => {
-        let customer = db.customers[review.customer_id];
+        const customer = db.customers[review.customer_id];
         if (customer.groups.indexOf('reviewer') === -1) {
             customer.groups.push('reviewer');
         }

examples/demo/src/dataProvider/index.ts

@@ -4,7 +4,7 @@ import fakeServerFactory from '../fakeServer';
 export default (type: string) => {
     // The fake servers require to generate data, which can take some time.
     // Here we start the server initialization but we don't wait for it to finish
-    let dataProviderPromise = getDataProvider(type);
+    const dataProviderPromise = getDataProvider(type);
 
     // Instead we return this proxy which may be called immediately by react-admin if the
     // user is already signed-in. In this case, we simply wait for the dataProvider promise

examples/demo/src/reviews/ReviewList.tsx

@@ -60,7 +60,7 @@ const ReviewList = () => {
                         theme.transitions.create(['all'], {
                             duration: theme.transitions.duration.enteringScreen,
                         }),
-                    marginRight: !!match ? '400px' : 0,
+                    marginRight: match ? '400px' : 0,
                 }}
                 filters={reviewFilters}
                 perPage={25}
@@ -73,7 +73,7 @@ const ReviewList = () => {
                 ) : (
                     <ReviewListDesktop
                         selectedRow={
-                            !!match
+                            match
                                 ? parseInt((match as any).params.id, 10)
                                 : undefined
                         }

packages/ra-core/src/controller/edit/useEditController.spec.tsx

@@ -1120,7 +1120,7 @@ describe('useEditController', () => {
     });
 
     it('should return errors from the update call in pessimistic mode', async () => {
-        let post = { id: 12 };
+        const post = { id: 12 };
         jest.spyOn(console, 'error').mockImplementationOnce(() => {});
         const update = jest.fn().mockImplementationOnce(() => {
             return Promise.reject({ body: { errors: { foo: 'invalid' } } });