Skip to content

Commit 183a114

Browse files
committed
Remove roomId from method
1 parent 0858731 commit 183a114

4 files changed

Lines changed: 7 additions & 8 deletions

File tree

src/definition/accessors/IAnalytics.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,8 @@ export interface IAnalytics {
1515
/**
1616
* Sends event data to server for Analytics
1717
*
18-
* @param roomId the roomId of the Room
1918
* @param data the analytics data for the event
2019
* @return true
2120
*/
22-
sendEvent(roomId: string, data: IAnalyticsPayload): Promise<boolean>;
21+
sendEvent(data: IAnalyticsPayload): Promise<boolean>;
2322
}

src/server/accessors/Analytics.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { AnalyticsBridge } from '../bridges/AnalyticsBridge';
55
export class Analytics implements IAnalytics {
66
constructor(private analyticsBridge: AnalyticsBridge, private appId: string) { }
77

8-
public sendEvent(roomId: string, data: IAnalyticsPayload): Promise<boolean> {
9-
return this.analyticsBridge.doSendEvent(roomId, data, this.appId);
8+
public sendEvent(data: IAnalyticsPayload): Promise<boolean> {
9+
return this.analyticsBridge.doSendEvent(data, this.appId);
1010
}
1111
}

src/server/bridges/AnalyticsBridge.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,13 @@ import { AppPermissions } from '../permissions/AppPermissions';
66
import { BaseBridge } from './BaseBridge';
77

88
export abstract class AnalyticsBridge extends BaseBridge {
9-
public async doSendEvent(roomId: string, data: IAnalyticsPayload, appId: string): Promise<boolean> {
9+
public async doSendEvent(data: IAnalyticsPayload, appId: string): Promise<boolean> {
1010
if (this.hasAnalyticsPermission(appId)) {
11-
return this.sendEvent(roomId, data, appId);
11+
return this.sendEvent(data, appId);
1212
}
1313
}
1414

15-
protected abstract sendEvent(roomId: string, data: IAnalyticsPayload, appId: string): Promise<boolean>;
15+
protected abstract sendEvent(data: IAnalyticsPayload, appId: string): Promise<boolean>;
1616

1717
private hasAnalyticsPermission(appId: string): boolean {
1818
if (AppPermissionManager.hasPermission(appId, AppPermissions.analytics.default)) {

tests/test-data/bridges/analyticsBridge.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { IAnalyticsPayload } from '../../../src/definition/accessors';
22
import { AnalyticsBridge } from '../../../src/server/bridges';
33

44
export class TestsAnalyticsBridge extends AnalyticsBridge {
5-
public async sendEvent(roomId: string, data: IAnalyticsPayload, appId: string): Promise<boolean> {
5+
public async sendEvent(data: IAnalyticsPayload, appId: string): Promise<boolean> {
66
throw new Error('Method not implemented.');
77
}
88
}

0 commit comments

Comments
 (0)