Restructure#62
Draft
light-matters wants to merge 130 commits into
Draft
Conversation
What we want to support in terms of options is still an open question though.
Dealing with create function for now.
deciding on the 'final' call API how this could be implemented
In the process, (temporarily) messed up how anchors are specified. But back to a logical error.
discovered bug in create (tests failing)
(currently in the script section of test_timeline_ramp.py)
maybe a problem with origins known - needs more testing
Also, ramp expansion now seems to work properly.
also introduced logging and a package-level `config` file.
More consistent with other projects and tidier (I think).
This will help future integration with other wigner projects.
(no explicit value testing)
can't test ADwin machine object creation on this computer though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #66
Fixes #59
Fixes #63
Fixes #60
Fixes #30
Fixes #27
Fixes #25
Fixes #6
Fixes #2
Fixes #67
Fixes #84