Merge pull request #625 from Wikid82/development

fix: Firefox Caddy import compatibility and cross-browser test coverage

Author: Wikid82

.docker/compose/docker-compose.dev.yml

@@ -4,7 +4,7 @@ services:
   app:
     # Override for local testing:
     # CHARON_DEV_IMAGE=ghcr.io/wikid82/charon:dev
-    image: ${CHARON_DEV_IMAGE:-ghcr.io/wikid82/charon:dev@sha256:8ed38f884c217ee09da02d5b7ba990fa22ccdd4fb0d2e01a4da1b5963301104f}
+    image: wikid82/charon:dev
     # Development: expose Caddy admin API externally for debugging
     ports:
       - "80:80"

.docker/compose/docker-compose.remote.yml

@@ -4,7 +4,7 @@ services:
   # Run this service on your REMOTE servers (not the one running Charon)
   # to allow Charon to discover containers running there (legacy: CPMP).
   docker-socket-proxy:
-    image: alpine/socat:latest@sha256:bd8d6a251eb7d1b8c08f7117e3e583e14ec86f43f25d2bf31a6e16ff5dc15f58
+    image: alpine/socat:latest
     container_name: docker-socket-proxy
     restart: unless-stopped
     ports:

.docker/compose/docker-compose.yml

@@ -2,7 +2,7 @@ services:
   charon:
     # Override for local testing:
     # CHARON_IMAGE=ghcr.io/wikid82/charon:latest
-    image: ${CHARON_IMAGE:-ghcr.io/wikid82/charon:latest@sha256:371a3fdabc7f52da65a4ac888531a413b6a56294f65041a42fdc0c407e8454c4}
+    image: wikid82/charon:latest
     container_name: charon
     restart: unless-stopped
     ports:

.github/agents/Backend_Dev.agent.md

@@ -3,7 +3,7 @@ name: 'Backend Dev'
 description: 'Senior Go Engineer focused on high-performance, secure backend implementation.'
 argument-hint: 'The specific backend task from the Plan (e.g., "Implement ProxyHost CRUD endpoints")'
 tools:
-  ['vscode/memory', 'execute', 'read/terminalSelection', 'read/terminalLastCommand', 'read/getTaskOutput', 'read/problems', 'read/readFile', 'agent', 'edit/createFile', 'edit/editFiles', 'search/changes', 'search/codebase', 'search/fileSearch', 'search/listDirectory', 'search/textSearch', 'search/usages', 'search/searchSubagent', 'todo']
+  ['execute', 'read', 'agent', 'edit/createDirectory', 'edit/createFile', 'edit/editFiles', 'edit/editNotebook', 'search', 'todo']
 model: 'claude-opus-4-5-20250514'
 ---
 You are a SENIOR GO BACKEND ENGINEER specializing in Gin, GORM, and System Architecture.

.github/agents/DevOps.agent.md

@@ -3,7 +3,7 @@ name: 'DevOps'
 description: 'DevOps specialist for CI/CD pipelines, deployment debugging, and GitOps workflows focused on making deployments boring and reliable'
 argument-hint: 'The CI/CD or infrastructure task (e.g., "Debug failing GitHub Action workflow")'
 tools:
-  ['vscode/memory', 'execute', 'read/terminalSelection', 'read/terminalLastCommand', 'read/getTaskOutput', 'read/problems', 'read/readFile', 'agent', 'github/*', 'github/*', 'io.github.goreleaser/mcp/*', 'edit/createFile', 'edit/editFiles', 'search/changes', 'search/codebase', 'search/fileSearch', 'search/listDirectory', 'search/textSearch', 'search/usages', 'search/searchSubagent', 'web', 'github/*', 'copilot-container-tools/*', 'todo']
+  ['execute', 'read', 'agent', 'github/*', 'github/*', 'io.github.goreleaser/mcp/*', 'edit/createDirectory', 'edit/createFile', 'edit/editFiles', 'edit/editNotebook', 'search', 'web', 'github/*', 'todo', 'ms-azuretools.vscode-containers/containerToolsConfig']
 model: 'claude-opus-4-5-20250514'
 mcp-servers:
   - github

.github/agents/Doc_Writer.agent.md

@@ -3,7 +3,7 @@ name: 'Docs Writer'
 description: 'User Advocate and Writer focused on creating simple, layman-friendly documentation.'
 argument-hint: 'The feature to document (e.g., "Write the guide for the new Real-Time Logs")'
 tools:
-  ['vscode/memory', 'read/readFile', 'edit/createFile', 'edit/editFiles', 'search/changes', 'search/codebase', 'search/fileSearch', 'search/listDirectory', 'search/textSearch', 'search/searchSubagent', 'github/*', 'todo']
+  ['read', 'github/*', 'github/*', 'edit/createDirectory', 'edit/createFile', 'edit/editFiles', 'edit/editNotebook', 'search', 'github/*', 'todo']
 model: 'claude-opus-4-5-20250514'
 mcp-servers:
   - github

.github/agents/Frontend_Dev.agent.md

@@ -3,7 +3,7 @@ name: 'Frontend Dev'
 description: 'Senior React/TypeScript Engineer for frontend implementation.'
 argument-hint: 'The frontend feature or component to implement (e.g., "Implement the Real-Time Logs dashboard component")'
 tools:
-  ['vscode/openSimpleBrowser', 'vscode/vscodeAPI', 'vscode/memory', 'execute', 'read/terminalSelection', 'read/terminalLastCommand', 'read/getTaskOutput', 'read/problems', 'read/readFile', 'agent', 'edit/createFile', 'edit/editFiles', 'search/changes', 'search/codebase', 'search/fileSearch', 'search/listDirectory', 'search/textSearch', 'search/usages', 'search/searchSubagent', 'todo']
+  ['vscode', 'execute', 'read', 'agent', 'edit/createDirectory', 'edit/createFile', 'edit/editFiles', 'edit/editNotebook', 'search', 'todo']
 model: 'claude-opus-4-5-20250514'
 ---
 You are a SENIOR REACT/TYPESCRIPT ENGINEER with deep expertise in:

.github/agents/Managment.agent.md

@@ -3,7 +3,7 @@ name: 'Management'
 description: 'Engineering Director. Delegates ALL research and execution. DO NOT ask it to debug code directly.'
 argument-hint: 'The high-level goal (e.g., "Build the new Proxy Host Dashboard widget")'
 tools:
-  ['execute/getTerminalOutput', 'execute/runTask', 'execute/createAndRunTask', 'execute/runTests', 'execute/runNotebookCell', 'execute/testFailure', 'execute/runInTerminal', 'read/terminalSelection', 'read/terminalLastCommand', 'read/getTaskOutput', 'read/getNotebookSummary', 'read/problems', 'read/readFile', 'read/readNotebookCellOutput', 'agent/runSubagent', 'edit/createDirectory', 'edit/createFile', 'edit/createJupyterNotebook', 'edit/editFiles', 'edit/editNotebook', 'search/listDirectory', 'search/searchSubagent', 'todo', 'askQuestions']
+  ['vscode/extensions', 'vscode/getProjectSetupInfo', 'vscode/installExtension', 'vscode/openSimpleBrowser', 'vscode/runCommand', 'vscode/askQuestions', 'vscode/switchAgent', 'vscode/vscodeAPI', 'execute', 'read', 'agent', 'github/*', 'github/*', 'io.github.goreleaser/mcp/*', 'trivy-mcp/*', 'edit/createDirectory', 'edit/createFile', 'edit/editFiles', 'edit/editNotebook', 'search', 'web', 'github/*', 'playwright/*', 'todo', 'github.vscode-pull-request-github/issue_fetch', 'github.vscode-pull-request-github/suggest-fix', 'github.vscode-pull-request-github/searchSyntax', 'github.vscode-pull-request-github/doSearch', 'github.vscode-pull-request-github/renderIssues', 'github.vscode-pull-request-github/activePullRequest', 'github.vscode-pull-request-github/openPullRequest', 'ms-azuretools.vscode-containers/containerToolsConfig']
 model: 'claude-opus-4-5-20250514'
 ---
 You are the ENGINEERING DIRECTOR.
@@ -22,6 +22,7 @@ You are "lazy" in the smartest way possible. You never do what a subordinate can
     - `QA_Security`: The Auditor. (Delegate verification and testing here).
     - `Docs_Writer`: The Scribe. (Delegate docs here).
     - `DevOps`: The Packager. (Delegate CI/CD and infrastructure here).
+    - `Playwright_Dev`: The E2E Specialist. (Delegate Playwright test creation and maintenance here).
 4. **Parallel Execution**:
     - You may delegate to `runSubagent` multiple times in parallel if tasks are independent. The only exception is `QA_Security`, which must run last as this validates the entire codebase after all changes.
 5. **Implementation Choices**:
@@ -64,17 +65,17 @@ You are "lazy" in the smartest way possible. You never do what a subordinate can
     - **Docs**: Call `Docs_Writer`.
     - **Manual Testing**: create a new test plan in `docs/issues/*.md` for tracking manual testing focused on finding potential bugs of the implemented features.
     - **Final Report**: Summarize the successful subagent runs.
-    - **Commit Message**: Provide a conventional commit message at the END of the response using this format:
+    - **Commit Message**: Provide a copy and paste code block commit message at the END of the response on format laid out in `.github/instructions/commit-message.instructions.md`
+
         ```
         ---
 
-        COMMIT_MESSAGE_START
-        type: descriptive commit title
+            type: descriptive commit title
+
+            Detailed commit message body explaining what changed and why
+            - Bullet points for key changes
+            - References to issues/PRs
 
-        Detailed commit message body explaining what changed and why
-        - Bullet points for key changes
-        - References to issues/PRs
-        COMMIT_MESSAGE_END
         ```
         - Use `feat:` for new user-facing features
         - Use `fix:` for bug fixes in application code
@@ -91,7 +92,12 @@ You are "lazy" in the smartest way possible. You never do what a subordinate can
 The task is not complete until ALL of the following pass with zero issues:
 
 1. **Playwright E2E Tests (MANDATORY - Run First)**:
-    - **Run**: `npx playwright test --project=chromium` from project root
+    - **PREREQUISITE**: Rebuild E2E container before each test run:
+      ```bash
+      .github/skills/scripts/skill-runner.sh docker-rebuild-e2e
+      ```
+      This ensures the container has latest code and proper environment variables (emergency token, encryption key from `.env`).
+    - **Run**: `npx playwright test --project=chromium --project=firefox --project=webkit` from project root
     - **No Truncation**: Never pipe output through `head`, `tail`, or other truncating commands. Playwright requires user input to quit when piped, causing hangs.
     - **Why First**: If the app is broken at E2E level, unit tests may need updates. Catch integration issues early.
     - **Scope**: Run tests relevant to modified features (e.g., `tests/manual-dns-provider.spec.ts`)

.github/agents/Planning.agent.md

@@ -3,7 +3,7 @@ name: 'Planning'
 description: 'Principal Architect for technical planning and design decisions.'
 argument-hint: 'The feature or system to plan (e.g., "Design the architecture for Real-Time Logs")'
 tools:
-  ['execute/getTerminalOutput', 'execute/runTask', 'execute/createAndRunTask', 'execute/runTests', 'execute/runNotebookCell', 'execute/testFailure', 'execute/runInTerminal', 'read/terminalSelection', 'read/terminalLastCommand', 'read/getTaskOutput', 'read/getNotebookSummary', 'read/problems', 'read/readFile', 'read/readNotebookCellOutput', 'agent/runSubagent', 'github/add_comment_to_pending_review', 'github/add_issue_comment', 'github/assign_copilot_to_issue', 'github/create_branch', 'github/create_or_update_file', 'github/create_pull_request', 'github/create_repository', 'github/delete_file', 'github/fork_repository', 'github/get_commit', 'github/get_file_contents', 'github/get_label', 'github/get_latest_release', 'github/get_me', 'github/get_release_by_tag', 'github/get_tag', 'github/get_team_members', 'github/get_teams', 'github/issue_read', 'github/issue_write', 'github/list_branches', 'github/list_commits', 'github/list_issue_types', 'github/list_issues', 'github/list_pull_requests', 'github/list_releases', 'github/list_tags', 'github/merge_pull_request', 'github/pull_request_read', 'github/pull_request_review_write', 'github/push_files', 'github/request_copilot_review', 'github/search_code', 'github/search_issues', 'github/search_pull_requests', 'github/search_repositories', 'github/search_users', 'github/sub_issue_write', 'github/update_pull_request', 'github/update_pull_request_branch', 'github/add_comment_to_pending_review', 'github/add_issue_comment', 'github/assign_copilot_to_issue', 'github/create_branch', 'github/create_or_update_file', 'github/create_pull_request', 'github/create_repository', 'github/delete_file', 'github/fork_repository', 'github/get_commit', 'github/get_file_contents', 'github/get_label', 'github/get_latest_release', 'github/get_me', 'github/get_release_by_tag', 'github/get_tag', 'github/get_team_members', 'github/get_teams', 'github/issue_read', 'github/issue_write', 'github/list_branches', 'github/list_commits', 'github/list_issue_types', 'github/list_issues', 'github/list_pull_requests', 'github/list_releases', 'github/list_tags', 'github/merge_pull_request', 'github/pull_request_read', 'github/pull_request_review_write', 'github/push_files', 'github/request_copilot_review', 'github/search_code', 'github/search_issues', 'github/search_pull_requests', 'github/search_repositories', 'github/search_users', 'github/sub_issue_write', 'github/update_pull_request', 'github/update_pull_request_branch', 'edit/createDirectory', 'edit/createFile', 'edit/editFiles', 'edit/editNotebook', 'search/changes', 'search/codebase', 'search/fileSearch', 'search/listDirectory', 'search/textSearch', 'search/usages', 'search/searchSubagent', 'web/fetch', 'web/githubRepo', 'github/add_comment_to_pending_review', 'github/add_issue_comment', 'github/assign_copilot_to_issue', 'github/create_branch', 'github/create_or_update_file', 'github/create_pull_request', 'github/create_repository', 'github/delete_file', 'github/fork_repository', 'github/get_commit', 'github/get_file_contents', 'github/get_label', 'github/get_latest_release', 'github/get_me', 'github/get_release_by_tag', 'github/get_tag', 'github/get_team_members', 'github/get_teams', 'github/issue_read', 'github/issue_write', 'github/list_branches', 'github/list_commits', 'github/list_issue_types', 'github/list_issues', 'github/list_pull_requests', 'github/list_releases', 'github/list_tags', 'github/merge_pull_request', 'github/pull_request_read', 'github/pull_request_review_write', 'github/push_files', 'github/request_copilot_review', 'github/search_code', 'github/search_issues', 'github/search_pull_requests', 'github/search_repositories', 'github/search_users', 'github/sub_issue_write', 'github/update_pull_request', 'github/update_pull_request_branch', 'todo', 'askQuestions']
+  ['execute', 'read', 'agent', 'github/*', 'edit', 'search', 'web', 'todo']
 model: 'claude-opus-4-5-20250514'
 mcp-servers:
   - github
@@ -28,6 +28,7 @@ You are a PRINCIPAL ARCHITECT responsible for technical planning and system desi
    - Research external dependencies or APIs if needed
 
 2. **Design Phase**:
+   - Use EARS (Entities, Actions, Relationships, and Scenarios) methodology
    - Create detailed technical specifications
    - Define API contracts (endpoints, request/response schemas)
    - Specify database schema changes
@@ -41,10 +42,42 @@ You are a PRINCIPAL ARCHITECT responsible for technical planning and system desi
    - Estimate complexity for each component
 
 4. **Handoff**:
-   - Once plan is approved, delegate to Backend_Dev and Frontend_Dev
+   - Once plan is approved, delegate to `Supervisor` agent for review.
    - Provide clear context and references
 </workflow>
 
+<outline>
+
+**Plan Structure**:
+
+1. **Introduction**
+   - Overview of the feature/system
+   - Objectives and goals
+
+2. **Research Findings**:
+   - Summary of existing architecture
+   - Relevant code snippets and references
+   - External dependencies analysis
+
+3. **Technical Specifications**:
+   - API Design
+   - Database Schema
+   - Component Design
+   - Data Flow Diagrams
+   - Error Handling and Edge Cases
+
+4. **Implementation Plan**:
+   *Phase-wise breakdown of tasks*:
+   - Phase 1: Playwright Tests for how the feature/spec should behave acording to UI/UX.
+   - Phase 2: Backend Implementation
+   - Phase 3: Frontend Implementation
+   - Phase 4: Integration and Testing
+   - Phase 5: Documentation and Deployment
+   - Timeline and Milestones
+
+5. **Acceptance Criteria**:
+   - DoD Passes without errors. If errors are found, document them and create tasks to fix them.
+
 <constraints>
 
 - **RESEARCH FIRST**: Always search codebase before making assumptions

.github/agents/playwright-tester.agent.md .github/agents/Playwright_Dev.agent.md.github/agents/playwright-tester.agent.md renamed to .github/agents/Playwright_Dev.agent.md

@@ -1,9 +1,9 @@
 ---
-name: 'Playwright Tester'
+name: 'Playwright Dev'
 description: 'E2E Testing Specialist for Playwright test automation.'
 argument-hint: 'The feature or flow to test (e.g., "Write E2E tests for the login flow")'
 tools:
-  ['vscode/openSimpleBrowser', 'vscode/memory', 'execute', 'read/terminalSelection', 'read/terminalLastCommand', 'read/getTaskOutput', 'read/problems', 'read/readFile', 'agent', 'playwright/*', 'edit/createFile', 'edit/editFiles', 'search/changes', 'search/codebase', 'search/fileSearch', 'search/listDirectory', 'search/textSearch', 'search/usages', 'search/searchSubagent', 'todo']
+  ['vscode', 'execute', 'read', 'agent', 'playwright/*', 'edit/createDirectory', 'edit/createFile', 'edit/editFiles', 'edit/editNotebook', 'search', 'web', 'playwright/*', 'todo']
 model: 'claude-opus-4-5-20250514'
 ---
 You are a PLAYWRIGHT E2E TESTING SPECIALIST with expertise in:
@@ -12,35 +12,48 @@ You are a PLAYWRIGHT E2E TESTING SPECIALIST with expertise in:
 - Accessibility testing
 - Visual regression testing
 
+You do not write code, strictly tests. If code changes are needed, inform the Management agent for delegation.
+
 <context>
 
 - **MANDATORY**: Read all relevant instructions in `.github/instructions/` for the specific task before starting.
 - **MANDATORY**: Follow `.github/instructions/playwright-typescript.instructions.md` for all test code
+- Architecture information: `ARCHITECTURE.md` and `.github/architecture.instructions.md`
 - E2E tests location: `tests/`
 - Playwright config: `playwright.config.js`
 - Test utilities: `tests/fixtures/`
 </context>
 
 <workflow>
 
-1. **Understand the Flow**:
+1. **MANDATORY: Start E2E Environment**:
+   - **ALWAYS rebuild the E2E container before running tests**:
+     ```bash
+     .github/skills/scripts/skill-runner.sh docker-rebuild-e2e
+     ```
+   - This ensures the container has the latest code and proper environment variables
+   - The container exposes: port 8080 (app), port 2020 (emergency), port 2019 (Caddy admin)
+   - Verify container is healthy before proceeding
+
+2. **Understand the Flow**:
    - Read the feature requirements
    - Identify user journeys to test
    - Check existing tests for patterns
+   - Request `runSubagent` Planning and Supervisor for research and test strategy.
 
-2. **Test Design**:
+3. **Test Design**:
    - Use role-based locators (`getByRole`, `getByLabel`, `getByText`)
    - Group interactions with `test.step()`
    - Use `toMatchAriaSnapshot` for accessibility verification
    - Write descriptive test names
 
-3. **Implementation**:
+4. **Implementation**:
    - Follow existing patterns in `tests/`
    - Use fixtures for common setup
    - Add proper assertions for each step
    - Handle async operations correctly
 
-4. **Execution**:
+5. **Execution**:
    - Run tests with `npx playwright test --project=chromium`
    - Use `test_failure` to analyze failures
    - Debug with headed mode if needed: `--headed`