Skip to content

Commit b843ebb

Browse files
committed
fix: revert optimizations
so it seems 2 queries are slower than N+1 ?? I don't know why this became slower also the ID query timed out
1 parent 2fec5c2 commit b843ebb

3 files changed

Lines changed: 2 additions & 32 deletions

File tree

store/migrations/0024_alter_batch_id_alter_tool_id.py

Lines changed: 0 additions & 23 deletions
This file was deleted.

store/models.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -207,8 +207,7 @@ def tag_ids(self):
207207

208208
@cached_property
209209
def sorted_tags(self):
210-
# tags come sorted through its Meta ordering
211-
return self.tags.all()
210+
return self.tags.order_by('-priority', 'id')
212211

213212
@cached_property
214213
def reverting_batches(self):

store/views.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
from .serializers import BatchSimpleSerializer, BatchDetailSerializer, BatchCSVSerializer, EditSerializer, ToolSerializer, ToolStatsSerializer
1515
from django_filters.rest_framework import DjangoFilterBackend
1616
from tagging.filters import TaggingFilterBackend
17-
from tagging.models import Tag
1817

1918
class BatchView(generics.RetrieveAPIView):
2019
serializer_class = BatchDetailSerializer
@@ -47,12 +46,7 @@ class APIBatchView(BatchView):
4746

4847
class BatchesView(generics.ListAPIView):
4948
serializer_class = BatchSimpleSerializer
50-
queryset = (
51-
Batch.objects
52-
.select_related('tool')
53-
.prefetch_related('tags')
54-
.order_by('-ended')
55-
)
49+
queryset = Batch.objects.all().order_by('-ended')
5650
template_name = 'store/batches.html'
5751
filter_fields = ('user',)
5852
filter_backends = (TaggingFilterBackend,)

0 commit comments

Comments
 (0)