Skip to content

Commit ad231a1

Browse files
authored
Merge pull request #20 from Wikodit/fix/wik-webservice-hpa-replicas
fix(wik-webservice): omit replicas in deployment if HPA is enabled
2 parents 9f043ab + 84d163a commit ad231a1

5 files changed

Lines changed: 12 additions & 0 deletions

File tree

.github/workflows/lint-test.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,5 +208,8 @@ jobs:
208208
with:
209209
cluster_name: chart-testing
210210

211+
- name: Install Gateway API CRDs
212+
run: kubectl apply -f https://github.com/kubernetes-sigs/gateway-api/releases/download/v1.5.0/standard-install.yaml
213+
211214
- name: Run chart-testing (install)
212215
run: ct install --config ct.yaml

CONTRIBUTING.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,8 @@ maintainers:
105105
email: anthony@wikodit.fr
106106
- name: Jeremy Trufier
107107
email: jeremy@wikodit.fr
108+
- name: Yaniss Loisel
109+
email: yaniss@wikodit.fr
108110
keywords:
109111
- wikodit
110112
- <chart-specific-keywords>

charts/wik-webservice/Chart.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ maintainers:
1414
email: anthony@wikodit.fr
1515
- name: Jeremy Trufier
1616
email: jeremy@wikodit.fr
17+
- name: Yaniss Loisel
18+
email: yaniss@wikodit.fr
1719
keywords:
1820
- wikodit
1921
- webservice

charts/wik-webservice/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1037,3 +1037,4 @@ webservice:
10371037
| Wikodit | | <https://github.com/wikodit> |
10381038
| Anthony Domingue | <anthony@wikodit.fr> | |
10391039
| Jeremy Trufier | <jeremy@wikodit.fr> | |
1040+
| Yaniss Loisel | <yaniss@wikodit.fr> | |

charts/wik-webservice/templates/deployment.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,11 @@ metadata:
1414
pod-security.kubernetes.io/warn: {{ .Values.podSecurityStandard.level }}
1515
{{ end }}
1616
spec:
17+
{{- /* When the HPA owns scaling, omitting replicas prevents every (ArgoCD/helm) apply
18+
from resetting the HPA-managed count (scale-up would be reverted on each sync) */}}
19+
{{- if not .Values.horizontalPodAutoscaler.enabled }}
1720
replicas: {{ .Values.webservice.replicas }}
21+
{{- end }}
1822
revisionHistoryLimit: {{ .Values.webservice.revisionHistoryLimit }}
1923
selector:
2024
matchLabels:

0 commit comments

Comments
 (0)