fix: Update requires-python to support Python 3.13#1
Closed
amirthfultehrani wants to merge 1 commit into
Closed
Conversation
Owner
|
@amirthfultehrani, Thank you for bringing this to my attention and for the kind words! I’ve pushed the updates to my latest fork. I initially thought this was just a comment rather than a full PR, but the edit is now implemented in the fork. Closing this PR since the changes are already included. |
Author
|
Awesome, thank you very much for incorporating the fix @WilliamJudge94. I am glad I could help and I look forward to seeing your PR get merged upstream. Thank you again, @WilliamJudge94! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear @WilliamJudge94, may you be well!
Firstly, thank you for your excellent work on adding Python 3.13 support in your upstream PR #1778! For a business statistics class I am taking this semester, I wanted to experiment with ydata-profiling, but upon attempting installation, I ran into the
ERROR: No matching distribution found for ydata-profiling; so, having seen your develop branch, I was made happy.Upon attempting to install directly from your branch (pip install git+....), the process failed with the error:
ERROR: Package 'ydata-profiling' requires a different Python: 3.13.1 not in '<3.13,>=3.7.It appeared that the package metadata in
pyproject.tomlstill restricted the installation despite your code changes for 3.13 support being complete.Thus, this PR of mine proposes a one-line change to pyproject.toml: making it go from
requires-python = ">=3.7,<3.13"torequires-python = ">=3.7,<3.14". After applying this fix, I was able to successfully install your branch on my Python 3.13.1 environment.As a result, I submit this directly to your branch in hopes of consolidating your Python 3.13 effort and hopefully making your main PR even easier for the upstream maintainers to merge.
Thank you again for all your great work, @WilliamJudge94. A great day to you!