WIP: Set ucrt as default runtime library#206
Draft
Blackhex wants to merge 1 commit into
Draft
Conversation
1ff03d0 to
8c7ebdb
Compare
8c7ebdb to
24e1089
Compare
4c6da12 to
f0c3082
Compare
09e68aa to
5b48e40
Compare
db44a97 to
dfda95b
Compare
fd6269d to
1375dc9
Compare
76bc737 to
4bb51ca
Compare
2cde4b1 to
4c2d408
Compare
154a067 to
5cec2c5
Compare
ucrt as default runtime libraryucrt as default runtime library
Member
Author
|
With |
vejbomar
approved these changes
Jan 16, 2025
Member
vejbomar
left a comment
There was a problem hiding this comment.
Merging will need to wait until fix-va-list is merged but changes looks good to me, so approving now
5cec2c5 to
f333ea7
Compare
ucrt as default runtime libraryucrt as default runtime library
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As MinGW/MSYS2 considers
msvcrtdeprecated anducrtthe default option for the runtime, we should useucrtas default as well.