Skip to content

WIP: Set ucrt as default runtime library#206

Draft
Blackhex wants to merge 1 commit into
mainfrom
default-ucrt
Draft

WIP: Set ucrt as default runtime library#206
Blackhex wants to merge 1 commit into
mainfrom
default-ucrt

Conversation

@Blackhex
Copy link
Copy Markdown
Member

@Blackhex Blackhex commented Oct 11, 2024

As MinGW/MSYS2 considers msvcrt deprecated and ucrt the default option for the runtime, we should use ucrt as default as well.

@Blackhex Blackhex force-pushed the default-ucrt branch 2 times, most recently from 1ff03d0 to 8c7ebdb Compare October 22, 2024 18:34
@Blackhex Blackhex force-pushed the main branch 2 times, most recently from 4c6da12 to f0c3082 Compare December 8, 2024 15:45
@Blackhex Blackhex force-pushed the default-ucrt branch 11 times, most recently from 09e68aa to 5b48e40 Compare December 16, 2024 13:07
@Blackhex Blackhex force-pushed the default-ucrt branch 11 times, most recently from db44a97 to dfda95b Compare December 23, 2024 13:46
@Blackhex Blackhex force-pushed the default-ucrt branch 2 times, most recently from 76bc737 to 4bb51ca Compare December 31, 2024 10:17
@Blackhex Blackhex force-pushed the default-ucrt branch 4 times, most recently from 2cde4b1 to 4c2d408 Compare January 6, 2025 20:32
@Blackhex Blackhex force-pushed the default-ucrt branch 2 times, most recently from 154a067 to 5cec2c5 Compare January 13, 2025 15:17
@Blackhex Blackhex changed the title WIP: Set ucrt as default runtime library Set ucrt as default runtime library Jan 13, 2025
@Blackhex Blackhex requested review from Copilot, eukarpov and vejbomar and removed request for eukarpov January 13, 2025 19:19
@Blackhex
Copy link
Copy Markdown
Member Author

With fix-va-list fixes, the ucrt build is now stable.

@Blackhex Blackhex marked this pull request as ready for review January 13, 2025 19:20
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • .github/scripts/config.ps1: Language not supported
  • .github/scripts/config.sh: Language not supported
  • tests/CMakeLists.txt: Language not supported

Copy link
Copy Markdown
Member

@vejbomar vejbomar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging will need to wait until fix-va-list is merged but changes looks good to me, so approving now

@Blackhex Blackhex changed the title Set ucrt as default runtime library WIP: Set ucrt as default runtime library Jun 2, 2025
@Blackhex Blackhex marked this pull request as draft June 2, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants