fix: unset animationAssetIds to allow player-set animations#170
Open
intheviewof wants to merge 1 commit into
Open
fix: unset animationAssetIds to allow player-set animations#170intheviewof wants to merge 1 commit into
animationAssetIds to allow player-set animations#170intheviewof wants to merge 1 commit into
Conversation
this appears to allow users to specify custom animations in their avatar in GameConfig.toml
Contributor
WalkthroughThe v463 character appearance endpoint now returns an empty ChangesCharacter appearance endpoint
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
animationAssetIds to allow player-set animations
Collaborator
|
@intheviewof Stylish Run also does not work for me, even if remove those animation ids. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
quick hack to allow player specified r15 animations (walk, run, etc) by unsetting hardcoded asset ids. this allow users to edit their GameConfig.toml and specify the IDs of animations they wish to use (i.e: Stylish Run)
tested & working on 2018 and 2021. i only tested this very lightly but this single change shouldn't have any negative effects
not my discovery, but i can't remember who found it first
tested with the following accessory data:
Summary by CodeRabbit