optimize CompoundTag map compares#701
Open
hayanesuru wants to merge 2 commits intover/1.21.11from
Open
Conversation
HaHaWTH
requested changes
Apr 10, 2026
|
|
||
| @Override | ||
| public CompoundTag copy() { | ||
| + // Leaf start - Further reduce memory footprint of CompoundTag | ||
| + if (this.tags instanceof org.dreeam.leaf.util.map.StringCanonizingOpenHashMap<Tag> stringCanonizingTags) { | ||
| + return new CompoundTag(org.dreeam.leaf.util.map.StringCanonizingOpenHashMap.deepCopy(stringCanonizingTags, Tag::copy)); | ||
| + org.dreeam.leaf.util.map.StringCanonizingOpenHashMap<Tag> ret = new org.dreeam.leaf.util.map.StringCanonizingOpenHashMap<>(stringCanonizingTags.size(), 0.8f); |
Member
There was a problem hiding this comment.
I'm curious about how much improvement this patch can bring, as we ignored the load factor of the original map when copying, rehashing cost is expensive.
I suggest add another method getLoadFactor in the StringCanonizingOpenHashMap to reuse load factor
| final Map<?, ?> m = (Map<?, ?>)o; | ||
| if (m.size() != size()) return false; | ||
| if (containsNullKey) { | ||
| if (!value[n].equals(m.get(key[n]))) { |
Member
There was a problem hiding this comment.
Should we use Objects.equals here to guard against null values? And use m.containsKey(key) to ensure the key exists, null == null is always true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#646
avoid map entry and iterator overhead
inline
StringCanonizingOpenHashMap#deepCopy