Limit dont-save entity config to chunk serialization only#710
Open
XUANHLGG wants to merge 1 commit intoWinds-Studio:ver/1.21.4from
Open
Limit dont-save entity config to chunk serialization only#710XUANHLGG wants to merge 1 commit intoWinds-Studio:ver/1.21.4from
XUANHLGG wants to merge 1 commit intoWinds-Studio:ver/1.21.4from
Conversation
Member
|
Hi, looks like you linked a Leaf 1.21.4 issue. However, Leaf 1.21.4 is marked as unsupported and will not receive any updates. Can you replicate this issue on the latest Leaf 1.21.11? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This option were meant to prevent falling blocks and primed TNT from being written to chunk entity data, but the old implementation applied them through shouldBeSaved(), which is also used during chunk unload. As a result, those entities could bypass the normal unload/remove path and remain in memory. This change limits the handling to saveEntityChunk0(), so falling blocks and primed TNT are still unloaded normally while remaining excluded from chunk saves.
#606