Fix MC-152094#727
Open
HaHaWTH wants to merge 6 commits intover/1.21.11from
Open
Conversation
nice try, but...
I dont want to risk threading issue, just use ThreadLocal
3 tasks
Dreeam-qwq
added
the
status: docs update required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workaround for MC-152094, where End City ships can sometimes be generated partially cut off at chunk borders.
RCA
End City ship pieces are sometimes being placed outside the vanilla structure reference search area (8 chunks). Which causes the cutoff.
This PR fixes by retracting the ship position if it's about to be cut off, as expanding the search area is too invasive (performance issue and used by almost the whole chunk system)
Reproduce
Seed:
1463345073146333179Pos:
-2680 140 -880