Add support for electron v43 prebuilds#1490
Conversation
neoxpert
left a comment
There was a problem hiding this comment.
Compiled and ran basic tests on Linux (Arch) and MacOS (26.5.2).
|
@neoxpert Thank you |
|
@neoxpert Build failing on Linux. Can you check your compiler setup against the ones from the containers in the build script? |
|
I guess that the used gcc-12 in the node20:bookworm container has trouble with properly resolving the macros used in the v8 headers. I'll have a deeper look tomorrow, but we might need to change the used Debian / gcc version or extend the build script. |
|
Perfect. Lemme know. Also, @JoshuaWise, can we please merge #1487? There's no other easy way to test it all locally. |
|
So it looks like gcc-12, which ships with bookworm, is "too old". After testing several setups using the node images, there are several options to counter the failed build.
|
Prebuilds were tested on Windows. But would love to test all with #1487.