Skip to content

Add support for electron v43 prebuilds#1490

Merged
m4heshd merged 1 commit into
WiseLibs:masterfrom
m4heshd:electron-43-prebuilds
Jul 3, 2026
Merged

Add support for electron v43 prebuilds#1490
m4heshd merged 1 commit into
WiseLibs:masterfrom
m4heshd:electron-43-prebuilds

Conversation

@m4heshd

@m4heshd m4heshd commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Prebuilds were tested on Windows. But would love to test all with #1487.

@m4heshd m4heshd requested review from a team and JoshuaWise as code owners June 30, 2026 08:22

@neoxpert neoxpert left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiled and ran basic tests on Linux (Arch) and MacOS (26.5.2).

@m4heshd

m4heshd commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

@neoxpert Thank you

@m4heshd m4heshd merged commit 9638b11 into WiseLibs:master Jul 3, 2026
26 checks passed
@m4heshd

m4heshd commented Jul 4, 2026

Copy link
Copy Markdown
Contributor Author

@neoxpert Build failing on Linux. Can you check your compiler setup against the ones from the containers in the build script?

@neoxpert

neoxpert commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

I guess that the used gcc-12 in the node20:bookworm container has trouble with properly resolving the macros used in the v8 headers. I'll have a deeper look tomorrow, but we might need to change the used Debian / gcc version or extend the build script.

@m4heshd

m4heshd commented Jul 5, 2026

Copy link
Copy Markdown
Contributor Author

Perfect. Lemme know. Also, @JoshuaWise, can we please merge #1487? There's no other easy way to test it all locally.

@neoxpert

neoxpert commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

So it looks like gcc-12, which ships with bookworm, is "too old". After testing several setups using the node images, there are several options to counter the failed build.

  • We could either lift the image for the modern Electron builds to trixie, which has gcc-14. This might lead to new issues due to libc version conflicts on target systems.
  • We could go down the road of building gcc-13 within the bookworm container (which would take some time ...) or inject a prebuilt version as it is not available within the bookworm repo.
  • Introduce another new step for electron to build everything beginning with 43.0.0 with trixie while continue building the old versions in the bookworm container ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants