Mody ADC_GetConversionValue return data#14
Open
scarletwiz wants to merge 1 commit into
Open
Conversation
jaredmauch
approved these changes
May 1, 2025
jaredmauch
left a comment
jaredmauch
left a comment
There was a problem hiding this comment.
Very straightforward fix. I'm also going to be sending some PRs for the DNS and IP settings work as well. Hopefully they will accept these merges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original ADC_GetConversionValue function had a return statement defined only within an if statement,
leading to a warning because an unspecified value would be returned if the if statement did not execute.
This update modifies the code to ensure a return value of 0 when the if statement does not execute, addressing the issue of returning an undefined value.