refactor: update InstallPackageAsync and UpdatePackageListAsync methods to use async/await pattern and simplify observable subscriptions

Author: WolfBublitz

src/PackageManager/AptPackageManager.cs

@@ -15,24 +15,24 @@ internal sealed class AptPackageManager : PackageManager
     public sealed override Task<bool> VerifyAsync(CancellationToken cancellationToken)
         => Process.CheckIfExecutableExistsAsync(ExecutablePath, ["--version"], cancellationToken);
 
-    public sealed override Task InstallPackageAsync(string packageName, CancellationToken cancellationToken)
+    public sealed async override Task InstallPackageAsync(string packageName, CancellationToken cancellationToken)
     {
         Process process = new(ExecutablePath, "install", "-y", packageName);
 
         using IDisposable stdOutSubscription = process.StdOut.Subscribe(OnStdOut);
         using IDisposable stdErrSubscription = process.StdErr.Subscribe(OnStdErr);
 
-        return process.ExecuteAsync(cancellationToken);
+        await process.ExecuteAsync(cancellationToken).ConfigureAwait(false);
     }
 
-    public sealed override Task UpdatePackageListAsync(CancellationToken cancellationToken)
+    public sealed async override Task UpdatePackageListAsync(CancellationToken cancellationToken)
     {
         Process process = new(ExecutablePath, "update");
 
         using IDisposable stdOutSubscription = process.StdOut.Subscribe(OnStdOut);
         using IDisposable stdErrSubscription = process.StdErr.Subscribe(OnStdErr);
 
-        return process.ExecuteAsync(cancellationToken);
+        await process.ExecuteAsync(cancellationToken).ConfigureAwait(false);
     }
     public sealed override async Task<bool> CheckIfPackageIsInstalledAsync(string packageName, CancellationToken cancellationToken)
     {

src/PackageManager/HomebrewPackageManager.cs

@@ -15,24 +15,24 @@ internal sealed class HomebrewPackageManager : PackageManager
     public sealed override Task<bool> VerifyAsync(CancellationToken cancellationToken)
         => Process.CheckIfExecutableExistsAsync(ExecutablePath, ["--version"], cancellationToken);
 
-    public sealed override Task InstallPackageAsync(string packageName, CancellationToken cancellationToken)
+    public sealed async override Task InstallPackageAsync(string packageName, CancellationToken cancellationToken)
     {
         Process process = new(ExecutablePath, "install", packageName);
 
         using IDisposable stdOutSubscription = process.StdOut.Subscribe(OnStdOut);
         using IDisposable stdErrSubscription = process.StdErr.Subscribe(OnStdErr);
 
-        return process.ExecuteAsync(cancellationToken);
+        await process.ExecuteAsync(cancellationToken).ConfigureAwait(false);
     }
 
-    public sealed override Task UpdatePackageListAsync(CancellationToken cancellationToken)
+    public sealed async override Task UpdatePackageListAsync(CancellationToken cancellationToken)
     {
         Process process = new(ExecutablePath, "update");
 
         using IDisposable stdOutSubscription = process.StdOut.Subscribe(OnStdOut);
         using IDisposable stdErrSubscription = process.StdErr.Subscribe(OnStdErr);
 
-        return process.ExecuteAsync(cancellationToken);
+        await process.ExecuteAsync(cancellationToken).ConfigureAwait(false);
     }
     public sealed override async Task<bool> CheckIfPackageIsInstalledAsync(string packageName, CancellationToken cancellationToken)
     {

src/PackageManager/PackageManager.cs

@@ -7,15 +7,15 @@ namespace DevEnv;
 
 internal abstract class PackageManager : IPackageManager, IDisposable
 {
-    private readonly ReplaySubject<string> stdOut = new();
+    private readonly Subject<string> stdOut = new();
 
-    private readonly ReplaySubject<string> stdErr = new();
+    private readonly Subject<string> stdErr = new();
 
     public abstract string Name { get; internal set; }
 
-    public Observable<string> StdOut => stdOut.AsObservable();
+    public Observable<string> StdOut => stdOut;
 
-    public Observable<string> StdErr => stdErr.AsObservable();
+    public Observable<string> StdErr => stdErr;
 
     public abstract Task<bool> VerifyAsync(CancellationToken cancellationToken);
 

tests/PackageManagerTests/AptPackageManagerTests/src/MethodTests/UpdatePackageListAsyncMethodTests.cs

@@ -16,7 +16,7 @@ public async Task ShouldUpdatePackageListSuccessfully(CancellationToken cancella
         // Arrange
         List<string> stdOut = [];
         AptPackageManager packageManager = new();
-        packageManager.StdOut.Subscribe(line => stdOut.Add(line));
+        packageManager.StdOut.Subscribe(stdOut.Add);
 
         // Act
         await packageManager.UpdatePackageListAsync(cancellationToken).ConfigureAwait(false);

tests/PackageManagerTests/HomebrewTests/src/HomebrewPackageManagerTests/MethodTests/UpdatePackageListAsyncMethodTests.cs

@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using System.Threading;
@@ -14,14 +15,14 @@ public sealed class TheUpdatePackageListAsyncMethod
     public async Task ShouldUpdatePackageListSuccessfully(CancellationToken cancellationToken)
     {
         // Arrange
-        List<string> stdOut = [];
+        List<string> stdError = [];
         HomebrewPackageManager packageManager = new();
-        packageManager.StdOut.Subscribe(stdOut.Add);
+        using IDisposable subscription = packageManager.StdErr.Subscribe(stdError.Add);
 
         // Act
         await packageManager.UpdatePackageListAsync(cancellationToken).ConfigureAwait(false);
 
         // Assert
-        stdOut.Last().Should().Contain("Reading package lists... Done", because: "The package list update should complete successfully.");
+        stdError.First().Should().Contain("Updating Homebrew", because: "The package list update should complete successfully.");
     }
 }