diff --git a/scripts/save_release_notes.sh b/scripts/save_release_notes.sh index 33f6f016..33590ae4 100755 --- a/scripts/save_release_notes.sh +++ b/scripts/save_release_notes.sh @@ -21,7 +21,7 @@ # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE # SOFTWARE. -set -euo pipefail +set -eu trap 'printf "Interrupted. Cleaning up...\n" >&2' INT TERM @@ -31,11 +31,12 @@ trap 'printf "Interrupted. Cleaning up...\n" >&2' INT TERM save_release_notes() { if [ "$#" -ne 1 ] && [ -z "${RELEASE_ID:-}" ]; then printf "Usage: %s [release_id]\n" "$0" >&2 + exit 1 fi - local release_id; release_id="${1:-${RELEASE_ID:-}}" - local github_token; github_token="${GH_TOKEN:-}" - local repo; repo="${GITHUB_REPOSITORY:-}" + release_id="${1:-${RELEASE_ID:-}}" + github_token="${GH_TOKEN:-}" + repo="${GITHUB_REPOSITORY:-}" if [ -z "$release_id" ]; then printf "Error: RELEASE_ID environment variable or argument is required.\n" >&2 @@ -54,27 +55,28 @@ save_release_notes() { # 1. Generate filename: NTE-DDHYM # Optimization: Single date call reduces process spawning. - # Using Bash string manipulation instead of cut/printf. # DD: Day of month (01-31) # H: Hour of day (0-N for 0-23) # Y: Last digit of year # M: Month (1-C for 1-12) - local dd h_val y_val m_val vars - vars=$(date "+%d %-H %y %-m") + vars=$(date "+%d %H %y %m") + dd=$(echo "$vars" | cut -d' ' -f1) + h_val=$(echo "$vars" | cut -d' ' -f2) + y_val=$(echo "$vars" | cut -d' ' -f3) + m_val=$(echo "$vars" | cut -d' ' -f4) - read -r dd h_val y_val m_val <